Conversation
jprzimba
commented
Sep 28, 2026
jprzimba
commented
- Iterate equipped slots directly instead of building a per-tick map (removes getAllSlotItems from header and source) to avoid allocations and improve performance.
- Simplify Item::getImbuementInfo by caching the CustomAttribute lookup, returning early if missing, and extracting the stored info without redundant calls.
- Minor cleanup related to these changes.
- Iterate equipped slots directly instead of building a per-tick map (removes getAllSlotItems from header and source) to avoid allocations and improve performance. - Simplify Item::getImbuementInfo by caching the CustomAttribute lookup, returning early if missing, and extracting the stored info without redundant calls. - Minor cleanup related to these changes.
|
that looks interesting... will test it today and give a feedback in 12h or so. |
|
yup the performance is noticeable seems much better but noticed one issue that i dont know if it is related but npcs seems to ignore imbuements and despite having unchecked the "Sell Equipped" they buy equipped items, not for every player it seems random case tho. |
will check, thank you for feedback |
In my tests, I didn't encounter any issues related to "Sell Equipped", it only sells the item when the option is actually checked. I tested with both compiled branches "main" and "imbuements" using their respective executables, and the results were the same. |
2 participants
