Implemented Buffer destructor mode - #44
Open
ydayan wants to merge 1 commit into
Open
Conversation
added "wrap_buffer" functions to Input and Output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi :)
I use your library in order to decode jpegs from a
Vecto a video, also as aVec.In order to do so I use the "wrap" function of the output context on an
AVFromatContextI create myself.The problem is, the
Outputdestructor mode assumes it opened a file (which I have not) and performsavio_closeon theptr, which causes a double free.Therefore, I added a third destructor mode "Buffer" that only preforms avformat_free_context. I myself am not sure about the name "Buffer", but it's better than "NotFile" so I'm open for suggestoins.
Also, If you would like, I can open a follow-up PR that adds my implementation of the in-memory context.
Thank you and waiting to here from you soon :)