Repository navigation
D-CE64-SEM-0: prove semantic upper-half transition loop - #1393
Conversation
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 19 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 60 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97789b2ed7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
#1391 moved the Pearl ladder out of this probe into lance_graph_planner::pearl. The four D-CE64-SEM-0 tests are ported onto the production API: revise(&Measured, Reading), hydrate(.., Reading), and the orientation test compares what the operator computed, since a Measured now carries the edge it measured. Uses div_ceil for the activation quantizer (clippy manual_div_ceil). No behaviour change to the probe's printed script. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0177nSSyQaXqbNuGR1vMXXN6
|
Merged
All 4 tests pass. Clippy Findings on the proposed readingsEach of the three new readings reuses bits that already mean something in code:
None of this affects production while the readings stay test-only and the layout is unchanged. Before any of them gets a contract name, each needs either its own bits or an explicit decision to take these bits over. Generated by Claude Code |
population_novelty returned 0 for both a single surviving EpistemicState5 and an empty population (contradictory facts such as DIRECT | INDIRECT), so a contradiction read as certainty (codex review). It now returns Option<u8>: None for no surviving state, Some(0) for one. The novelty test pins the contradiction case; a disable run mapping the empty population back to Some(0) turns it red. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0177nSSyQaXqbNuGR1vMXXN6
Same regeneration as #1394, so regenerate-and-diff passes on this PR; it no-ops once main carries #1394. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0177nSSyQaXqbNuGR1vMXXN6
#1393 merged without a board record. Records what it added, what is pinned, and the open review findings (each reading reuses bits that already carry a meaning; its tests are not run by CI). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0177nSSyQaXqbNuGR1vMXXN6
Claim under test
Exercise the proposed CausalEdge64 upper-half reading on the real D-PEARL-IO-0 fixture without changing the wire layout or production enum names.
Probe-local candidate reading:
Falsifiers
Scope
If this survives CI, the next question is whether these alternate readings deserve contract names or should remain experimental.