Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusing an
HTML2Textinstance can add a leading space to emphasized text in later documents. For example, callinghandle("<em>hello</em>")twice produces_hello_first and_hello_second. Text from a previous plain document can also affect a later emphasized document.Clear
preceding_dataat the start ofhandle, alongside the existingstartreset, so spacing decisions only inspect the current document. Add repeated-call cases across all eight emphasis/strike tags and a cross-document case. Update the changelog and contributor list as requested by the contribution guide.Related to #375. #362 resets
startfor repeated calls, but leaves the text used by emphasis spacing intact.Validation on Linux/arm64:
mypy --strict html2textpass.AI assistance: this change and its tests were developed and verified with an AI coding agent.