Repository navigation
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Set core sensor update intervals Integrations/ESPHome/Core.yaml |
The DPS310 interval changes from 30 to 60 seconds. The SEN55 and four particulate-matter template sensor intervals change from 10 to 60 seconds. |
Set predicted-room update intervals Integrations/ESPHome/Predicted_Room.yaml |
The predicted room temperature and humidity sensor intervals change from 10 to 60 seconds. Their calculation and validation logic is unchanged. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Possibly related PRs
- ApolloAutomation/AIR-1#135: Adds the predicted room sensors that use SEN55 and DPS310 readings. This change updates the intervals for those sensors and their source sensors.
Suggested reviewers: trevorschirmer, bharvey88
Merge Risk: 
Minimal · up to 10790
-
The interval changes are consistent with the PR’s stated database-growth reduction goal and are ready to merge.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the sensor pace,
Sixty seconds mark each place.
Air readings wait, then start anew,
Room predictions follow too.
The rabbit hops and checks the view.
Comment @coderabbitai help to get the list of available commands.
03c5daa to
107906b
Compare
|
I'm now running beta plus this, plus two unrelated fixes, and it's working fine. |
Version: 26.10.16.1
What does this implement/fix?
(Do you really want the instructions/comments to remain?)
Many sensors report faster than one minute. If you have Home Assistant and a single AIR-1, that's probably fine. With lots of sensors, the database grows large. The underlying reality just doesn't change that fast, and I believe that almost all people would not find faster-than-1m to be beneficial.
This change is technically breaking, because someone could be relying on it, but it is a bugfix for everyone who does not want such rapid reports and has a big database. But the frequencies are not documented, so arguably it is not breaking.
20261025: I just force-pushed an amended commit that also sets the Predicted entities to 60s update rate.
Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
Summary by CodeRabbit