Repository navigation
Keep a phone number written in ordinary words out of public GitHub issues - #34
Merged
aryanorastar merged 1 commit intoOct 11, 2026
Conversation
The redaction only saw a phone word when it stood right before the digits with at most one joining word. "Phone number: 9876543210", "my phone number is ..." and "call me on ..." went into the public GitHub issue unchanged. It now accepts a few joining words, and knows mobile, cell, contact, ph and tel. as phone words.
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer problem
A customer who writes "Phone number: 9876543210" or "my phone number is 9876543210" in a bug report gets that number published in the public GitHub issue.
redactSensitiveonly saw a phone word when it stood right before the digits with at most one joining word, so these went through unchanged, as did "call me on …", "Mobile …", "cell: …" and "tel. 020 7946 0958".Change
The phone context accepts a few joining words between the phone word and the digits (number, no., is, me, us, at, on,
:,=,#,-), and knows mobile, cell, contact, ph, "my number" and telephone in Spanish, French, Portuguese, Italian and German. The digit rules are untouched, so builds, versions and serial numbers are still kept.Evidence
privacy.jssets the rule itself: public GitHub issues must never carry raw customer identifiers, on every filing path. I ran the old and the new redaction over every string literal in the repo's sources, tests and scripts (3187 of them): only the new test lines come out different.Verification
test/privacy.test.js. Two fail on main; the third keeps "On my phone the app is build 2026100312. Serial number is 0123456789012." unchangednpm test: 629/629EVAL_NO_MODEL=1 node scripts/customer-eval.js: 8/8.env, orrailway.toml(the numbers in the tests are made up)