Repository navigation
Restrict test workflow permissions - #50
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
BenWestgate
added
area: ci
This was referenced Sep 25, 2026
BenWestgate
added a commit
that referenced
this pull request
Sep 25, 2026
Declare contents: read for the two legacy master workflows flagged by CodeQL. This is a focused default-branch fix; reviewability-v1 already deletes pylint.yml and has PR #50 for its active test workflow.\n\nValidation: git diff --check.
BenWestgate
added a commit
that referenced
this pull request
Sep 25, 2026
Declare contents: read for the two legacy master workflows flagged by CodeQL. This is a focused default-branch fix; reviewability-v1 already deletes pylint.yml and has PR #50 for its active test workflow. Validation: git diff --check.
BenWestgate
commented
Sep 25, 2026
BenWestgate
left a comment
BenWestgate
left a comment
Owner
Author
There was a problem hiding this comment.
AI-generated review (Claude), posted at the maintainer's request.
ACK 1b08bac
publish.ymlalready scopes permissions per job; this was the only workflow without them.
Owner
Author
|
Code-scanning follow-up (2026-09-27): the default-branch side is now resolved by merged #58. The current |
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit read-only repository permissions to the active test workflow.
This addresses the CodeQL workflow-permissions finding that survives on
reviewability-v1. The separatepylint.ymlalert onmasteris obsoleted becausereviewability-v1deletes that workflow.Validation:
git diff --check; workflow-only YAML change.