Repository navigation
tests: consolidate bitcoind harness into workspace - #415
Merged
Merged
Conversation
Contributor
|
Please do not merge this without my ACK. I likely will need to update my local testing setup. |
Merged
Contributor
|
9f5d8b7 needs rebase |
KyrylR
marked this pull request as draft
October 5, 2026 12:25
Contributor
|
Got my local CI working on 9f5d8b7 So if you rebase I can approve/merge. (Not a very high prioritiy) |
KyrylR
force-pushed
the
feature/bitcoind-workspace-maintenance
branch
from
October 5, 2026 12:47
9f5d8b7 to
0f1a36c
Compare
KyrylR
marked this pull request as ready for review
October 5, 2026 12:49
Collaborator
Author
Yep, as soon as I saw your "needs rebase", was on it Rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reintroduces bitcoind-tests into the Cargo workspace
There were quite a few PRs that broke this crate. With that change CI will detect API changes that require corresponding updates
When cargo test is used, it won't touch this crate's tests because
ELEMENTS_EXEis not available on every system