await localeData + real RTL check#1044
Merged
Merged
Conversation
bearfriend
commented
Jul 22, 2026
| const defaultOpts = { | ||
| lang: DEFAULT_LANG, | ||
| mathjax: {}, | ||
| rtl: !!opts.lang?.startsWith('ar'), |
Contributor
Author
There was a problem hiding this comment.
*Urdu intensifies*
GZolla
approved these changes
Jul 22, 2026
dbatiste
approved these changes
Jul 22, 2026
|
🎉 This PR is included in version 1.50.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GAUD-9717: Rewrite intl/common and intl/dateTime to use contained data sets per locale
Since
fixturealready handles (re)setting the language it makes sense to have it handle waiting for locale data so consumers get this for free as well.Also changes the RTL logic to pull the actual locale layout data.