Skip to content

await localeData + real RTL check #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bearfriend merged 3 commits into from
Jul 22, 2026
Merged

await localeData + real RTL check #1044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c12f20c
await localeData + real RTL check
bearfriend Jul 22, 2026
bcc7f5d
Bump intl
bearfriend Jul 22, 2026
76f0076
Add ctor lang
bearfriend Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 12 additions & 11 deletions src/browser/reset.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { setViewport as cmdSetViewport, emulateMedia, sendMouse } from '@web/test-runner-commands';
import { getDocumentLocaleSettings } from '@brightspace-ui/intl/lib/common.js';
import { localeData } from '@brightspace-ui/intl/lib/locale-data/current.js';
import { nextFrame } from '@open-wc/testing';

const DEFAULT_PAGE_PADDING = true,
Expand Down Expand Up @@ -48,7 +49,6 @@ export async function reset(opts = {}) {
const defaultOpts = {
lang: DEFAULT_LANG,
mathjax: {},
rtl: !!opts.lang?.startsWith('ar'),

@bearfriend bearfriend Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Urdu intensifies*

colorMode: DEFAULT_COLOR_MODE,
pagePadding: DEFAULT_PAGE_PADDING,
media: DEFAULT_MEDIA
Expand Down Expand Up @@ -82,16 +82,6 @@ export async function reset(opts = {}) {
awaitNextFrame = true;
}

if (opts.rtl !== currentRtl) {
if (!opts.rtl) {
document.documentElement.removeAttribute('dir');
} else {
document.documentElement.setAttribute('dir', 'rtl');
}
awaitNextFrame = true;
currentRtl = opts.rtl;
}

if (opts.colorMode !== currentColorMode) {
const colorMode = ['light', 'dark'].includes(opts.colorMode) ? opts.colorMode : DEFAULT_COLOR_MODE;
if (!colorMode) {
Expand All @@ -106,7 +96,18 @@ export async function reset(opts = {}) {
opts.lang ??= '';
if (documentLocaleSettings.language !== opts.lang) {
document.documentElement.lang = opts.lang;
await localeData;
}

opts.rtl ??= localeData.layout.orientation.characterOrder === 'right-to-left';
if (opts.rtl !== currentRtl) {
if (!opts.rtl) {
document.documentElement.removeAttribute('dir');
} else {
document.documentElement.setAttribute('dir', 'rtl');
}
awaitNextFrame = true;
currentRtl = opts.rtl;
}

if (await setViewport(opts.viewport)) {
Expand Down
2 changes: 1 addition & 1 deletion test/browser/ctor.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ export default {
pattern: () => 'test/browser/**/*.ctor.js',
testRunnerHtml: testFramework =>
`<!DOCTYPE html>
<html>
<html lang="en">
<body>
<script>
window.addEventListener('error', (err) => {
Expand Down