Repository navigation
fix: PR hygiene runs every event to the end and lets the newest payload decide (port of #526, #529) - #530
Merged
Conversation
…ad decide (#526) The concurrency group cancelled every run still going when the next event arrived, and GitHub counts a cancelled run in the commit's status: 61 of the last 100 merged PRs showed FAILURE for nothing but cancelled hygiene runs. The group is gone, so no run is cancelled. Each run waits 20 s for a burst of events to settle, then compares its payload's head, base, labels and description with the PR as it is now. If any changed, the event that changed it started a newer run, so this one passes without checking. Measured on the throwaway PR #527; the numbers are in the workflow's header. Found-By: IS Defect-Class: PKG Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 0c0898f)
CaffeinatedCoder
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #529
Port of #528 (#526) to
release/10.x, cherry-picked with-x. It applies with no conflict, becausepr-hygiene.ymlis the same on both lines.Problem
The hygiene workflow runs from the PR's base. So PRs into
release/10.xkeep cancelling their own hygiene runs, and keep showing a red commit status beside green checks. #520 and #524 are two examples.Change
The same as #528. There's no concurrency group. Each run waits 20 s, then passes as superseded when the PR's head, base, labels or description changed after its event. Otherwise it runs
pr-hygiene.sh, which is unchanged.Tests
The measurements on #527 are in #528 and in the workflow's header. This PR's own hygiene runs are the check on this line.
🤖 Generated with Claude Code