Document capture text bytes and pin reconciliation comparison - #2933
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…covery Clear recovery announcements when retained Review warnings return
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fafe485494
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Independent review disposition at 815b40e: SHIP, no CRITICAL/HIGH. Six comparison cases pass; full backend at the unchanged code/test head fafe485 passed 9,358 tests with five existing skips. Final docs correction passes docs/link checks. Remaining MEDIUM correction-path wording stays on #2912; this partial PR does not close it. Current main's only delta from the tested base is #2924's Review disclosure guard and two frontend tests, with no overlap in these backend tests or capture documentation. |
…cope Keep retained Review health scoped to visible board data
…12/capture-comparison-integration
|
Merge qualification at5c1fc27a5f417f5707005a143e19945bdb191475: Required CI34518035036 succeeds; every exact-head check is success/skipped, all review threads are disposed, and the head is older than three minutes. Current maina0d05da47648c5a050db5e023f5227c5a14ddb69 adds only the five already-merged coordinator documentation/rule files to candidate tree49ff70bf087eef5597a8d72b39f8d04dd05ded08. Both backend and frontend trees are byte-identical to the reviewed/tested head. Current docs/governance/link checks pass; the control rule confirms no new gate for this non-control diff. Independent source and integrated-base reviews remain applicable. #2912 stays open for the recorded MEDIUM wording residual. |
Capture detail and durable account exports preserve stored source text, including its line endings. The API guide now names
durableCapture.sourceAssets[].textand the fallbacklegacySource.textused only when no durable capture exists. It distinguishes these from the LF queue projection produced by a correction; export does not promise universal LF normalization.The helper comment is scoped to reconciliation. Six direct tests pin CRLF/LF and bare-CR equivalence, significant whitespace/content differences, and null behavior. Runtime comparison and storage are unchanged. The bounded allocation note is declined because no measured issue justifies another mechanism.
Validation: six focused tests pass; full backend passes 9,358 tests with five existing skips at fafe485. Final head 815b40e changes only the documented export fields; docs governance, 690-file relative-link check and diff check pass again. Operations governance passes. No frontend or browser change.
Review found the older issue's general detail/export divergence claim was inaccurate for durable captures; the final wording follows the implementation. STATUS and MASTERPLAN are unchanged because this documents delivered behavior. Hosted qualification remains pending.
Refs #2912
Remaining MEDIUM documentation residual on #2912: the guide and helper comment say corrections normalize the queue; only linked-transcript correction does so. Ordinary suggestion edits preserve submitted text. The review ceiling is reached, so this narrower wording remains tracked and this PR does not close the parent issue.
Current-base qualification: integrated main 8aafe53 at head 5c1fc27. Six comparison tests, docs/governance/link checks and scoped independent base review pass. Backend tree is identical to the previously full-tested candidate; the base adds only already-reviewed Review frontend changes. Exact-head hosted CI remains required.