Skip to content

Document capture text bytes and pin reconciliation comparison - #2933

Merged
Chris0Jeky merged 9 commits into
mainfrom
issue-2912/capture-comparison
Sep 10, 2026
Merged

Chris0Jeky merged 9 commits into
mainfrom
issue-2912/capture-comparison

Conversation

@Chris0Jeky

@Chris0Jeky Chris0Jeky commented Sep 10, 2026

Copy link
Copy Markdown
Owner

Capture detail and durable account exports preserve stored source text, including its line endings. The API guide now names durableCapture.sourceAssets[].text and the fallback legacySource.text used only when no durable capture exists. It distinguishes these from the LF queue projection produced by a correction; export does not promise universal LF normalization.

The helper comment is scoped to reconciliation. Six direct tests pin CRLF/LF and bare-CR equivalence, significant whitespace/content differences, and null behavior. Runtime comparison and storage are unchanged. The bounded allocation note is declined because no measured issue justifies another mechanism.

Validation: six focused tests pass; full backend passes 9,358 tests with five existing skips at fafe485. Final head 815b40e changes only the documented export fields; docs governance, 690-file relative-link check and diff check pass again. Operations governance passes. No frontend or browser change.

Review found the older issue's general detail/export divergence claim was inaccurate for durable captures; the final wording follows the implementation. STATUS and MASTERPLAN are unchanged because this documents delivered behavior. Hosted qualification remains pending.

Refs #2912

Remaining MEDIUM documentation residual on #2912: the guide and helper comment say corrections normalize the queue; only linked-transcript correction does so. Ordinary suggestion edits preserve submitted text. The review ceiling is reached, so this narrower wording remains tracked and this PR does not close the parent issue.

Current-base qualification: integrated main 8aafe53 at head 5c1fc27. Six comparison tests, docs/governance/link checks and scoped independent base review pass. Backend tree is identical to the previously full-tested candidate; the base adds only already-reviewed Review frontend changes. Exact-head hosted CI remains required.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T19:05:24.826285Z 5c1fc27 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fafe485494

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/api/CAPTURE.md Outdated

Copy link
Copy Markdown
Owner Author

Independent review disposition at 815b40e: SHIP, no CRITICAL/HIGH. Six comparison cases pass; full backend at the unchanged code/test head fafe485 passed 9,358 tests with five existing skips. Final docs correction passes docs/link checks. Remaining MEDIUM correction-path wording stays on #2912; this partial PR does not close it. Current main's only delta from the tested base is #2924's Review disclosure guard and two frontend tests, with no overlap in these backend tests or capture documentation.

Chris0Jeky and others added 2 commits September 10, 2026 19:59
…cope

Keep retained Review health scoped to visible board data

Copy link
Copy Markdown
Owner Author

Merge qualification at5c1fc27a5f417f5707005a143e19945bdb191475: Required CI34518035036 succeeds; every exact-head check is success/skipped, all review threads are disposed, and the head is older than three minutes. Current maina0d05da47648c5a050db5e023f5227c5a14ddb69 adds only the five already-merged coordinator documentation/rule files to candidate tree49ff70bf087eef5597a8d72b39f8d04dd05ded08. Both backend and frontend trees are byte-identical to the reviewed/tested head. Current docs/governance/link checks pass; the control rule confirms no new gate for this non-control diff. Independent source and integrated-base reviews remain applicable. #2912 stays open for the recorded MEDIUM wording residual.

@Chris0Jeky
Chris0Jeky merged commit a61ed63 into main Sep 10, 2026
39 of 40 checks passed
@Chris0Jeky
Chris0Jeky deleted the issue-2912/capture-comparison branch September 10, 2026 19:30
@github-project-automation github-project-automation Bot moved this from Review to Done in Taskdeck Execution Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant