Make proposal review reflect ordered capacity and actual card effects - #3051
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Delivery is coordinated through integration PR #3050, which preserves this PR's exact source head and commits. It qualifies all reviewed product slices against main1931da65d after the Smart CI repair; no source merge-resolution changes were required. Local source evidence remains scoped to its recorded head, and the integration's hosted checks and bounded interaction review qualify the combined delivery. Existing review feedback is triaged once; this source PR will be reconciled after the integration lands. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7463be010
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Proposal validation now checks create, cross-column move and restore capacity in operation order, releasing slots only for earlier deletion or lifecycle archive of active cards. Review warnings use the same ordered occupancy and retain earlier peak violations. The Cards side-effect row names only the actual actions, including updates/deletes and the distinction between legacy Block and lifecycle archive/restore.
Existing producer timing and review-first execution stay intact: planner/policy/chat-create reject an over-capacity proposal during creation; direct API/MCP/chat-move retain their existing creation contract and review validation rejects it before Apply. Same-column moves and unlimited columns keep their existing behavior.
Validation at a7463be: 217 focused Application tests and 54 API/MCP cases pass. Sixteen disclosure regressions and fourteen ordered-capacity failures were reproduced before the fixes. The full backend suite passed: 9,600 tests, 34 existing skips, zero failures. Command: dotnet test backend/Taskdeck.sln -c Release -m:1 --disable-build-servers -p:UseSharedCompilation=false. Independent review found no merge blocker.
This branch preserves the capacity, validator and side-effect source commits. Integration PR #3050 contains this exact head with the parallel card-editor and assignment-notification repairs, canonical delivery records and final hosted qualification against current main. No schema, endpoint or control-plane change.
Closes #3012
Closes #3020
Closes #3031