Skip to content

Align card editor recovery and proposal review with server state - #3050

Merged
Chris0Jeky merged 24 commits into
mainfrom
codex/0912-product-integration
Sep 12, 2026
Merged

Chris0Jeky merged 24 commits into
mainfrom
codex/0912-product-integration

Conversation

@Chris0Jeky

@Chris0Jeky Chris0Jeky commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Card editor writes now reconcile permission after a confirmed 403, assignment revocation emits the actual affected card identities after commit, and proposal review models ordered capacity and describes only the card actions present. These changes keep editor controls and Review aligned with server decisions while preserving drafts and review-first application.

This integration preserves all source commits and qualifies them against main 1931da65d after the approved Smart CI fix #2987. It includes #3048 (card permission/archive focus), #3047 (assignment notifications), #3051 (proposal capacity/disclosure), #3046 (async extraction tests), #3043 (assignment/import delivery records), and #2914 (inert hosting compatibility). There were no merge-resolution edits. Only the coordinator's STATUS/MASTERPLAN record is additional.

Validation:

  • Card source 8582b7ac3: final typecheck/build, 175 focused tests and 3 native Chromium cases pass. Combined full frontend at 8ab19e7ef: 6,776 passed / 3 existing skips; the final bounded callback fix has scoped proof and independent verification.
  • Webhook source 4c2f60c59: full backend 9,564 passed / 34 existing skips; 5 SQLite regressions include transaction rollback and actual persisted metadata.
  • Extraction source 5e3e230ab: full backend 9,559 passed / 34 existing skips; 6 focused cases passed 5 runs.
  • Proposal source a7463be01: full backend 9,600 passed / 34 existing skips; 217 focused Application and 54 API/MCP cases pass. Full command: dotnet test backend/Taskdeck.sln -c Release -m:1 --disable-build-servers -p:UseSharedCompilation=false.
  • Final integration 05ed5bbad: docs governance, 699 Markdown files with zero broken relative links, and diff hygiene pass.
  • Independent source reviews and one bounded integration-interaction review found no merge blocker. All six source heads are ancestors. Final documentation delta was independently qualified. Exact integration hosted CI remains required before merge.

Limits: browser evidence uses synthetic HTTP fixtures; real backend permission integration and screen-reader output were not tested. Local backend skips include PostgreSQL/Docker cases. No hosting provisioning, activation, spending, deployment or repository settings change. Existing OUTSTANDING_TASKS human decisions stay open. CI-control PRs #2931/#2838 are excluded.

Review feedback is disposed once: remaining planning/hosting references are tracked in #3044; same-valued fresh board permission recovery in #3049; comment-delete dialog recovery in #3023. The #3033 pending archive busy-ownership residual, broader #3023 editor work and #3024 reliable delivery remain open. The source proposal's stale STATUS comment is addressed in this integration's coordinator-owned record.

Closes #2993
Closes #2979
Closes #3021
Closes #3037
Closes #3042
Closes #3012
Closes #3020
Closes #3031
Closes #3036

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-12T15:41:52.676607Z 05ed5bb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Final integration qualification at 05ed5bb: one independent Terra interaction review confirmed every supplied source head is preserved, all merges have no resolution changes, and no cross-slice blocker was found. Its final documentation-delta qualification is also clean. The source card review completed its one bounded fix verification; the separate same-valued payload P2 is tracked as #3049. Existing hosting/planning P2 feedback is tracked as #3044. No additional source review loop is planned absent a confirmed causal merge blocker. Exact-head hosted CI and the running proposal full backend gate remain required before merge.

@Chris0Jeky Chris0Jeky moved this from Pending to Review in Taskdeck Execution Sep 12, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 05ed5bbada

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/taskdeck-web/src/components/board/CardModal.vue
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Merged as 9c17a83bfb3a563dd3afa2691cf50439794028ff at 2026-09-12 16:24:23 UTC. Required workflow 34702720469 passed at reviewed head 05ed5bbada535137df3cce796987272e2b484414; the base remained 1931da65d8a629703a2a37e9e5fa2c1339795f60 before merge. The final Windows API job completed successfully, and the pushed head exceeded the three-minute aging gate.

GitHub now confirms source PRs #2914, #3043, #3046, #3047, #3048 and #3051 are merged with their commits preserved. All nine intended issues (#2979, #2993, #3012, #3020, #3021, #3031, #3036, #3037, #3042) are closed and their project items are Done with nonempty priorities. The partial archive residual #3033 remains open/Pending. The post-merge checkpoint found no unresolved review threads across this integration, its six source PRs, or #2987.

Local test logs, Chromium traces, regression diffs and fresh ignored-file inventories were preserved under C:/td0912-evidence before plain removal of the eight completed short-clone worktrees. The original OneDrive checkout and historical junction worktrees were left intact. The active estimate and permission-follow-up trees remain separate.

Real-device/screen-reader qualification, live webhook delivery, private-hosting activation and the CI-control maintainer decisions in OUTSTANDING_TASKS.md are unchanged. Project-wide priority audit recovery is tracked separately in #3052; only the shipping items above are verified here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment