Keep archive requests owned across card switches - #3059
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent read-only review at The issue's speculative generation hardening and mock-reactivity notices are explicitly declined as described in the PR. Component remount/independent-tab ownership is an existing boundary, not an introduced regression. No extra review or browser run is claimed. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0afcdd0f2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc7cbb948b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Merged as44d041ca7d819d450976fc974e14623718f2f467 after required workflow34714826369 passed at reviewed7135d53a9d046547c8860b3f757c79861820f36b. GitHub confirms #3033 closed; its issue and PR items are Done/PriorityIV. First post-merge check found zero unresolved threads. Child #3064 is retargeted to main and its new base is being qualified. #3060 and the remaining #3023 recovery-copy/other residuals remain separate; existing OUTSTANDING_TASKS.md human actions are unchanged. |
|
Post-delivery worktree cleanup is complete. Before plain git worktree remove, the source commit was verified as an ancestor of delivered main and the tree had no tracked/untracked changes. All 15 archive QA logs and handoffs were copied and SHA-256 checked at C:/td0912-evidence/delivered-archive-ownership; copied-hashes.json and pre-removal inventory retain the receipt. Rebuildable dist/node_modules were removed with the finished tree. Source history remains in main. |
Switching from card A to B and back to A while an archive/restore request was pending could enable A's action again. Keep pending ownership keyed by board/card in the mounted CardModal editor above its version-keyed action child. Other cards remain actionable; each settlement releases only its own card. Existing version resets, focus, confirmation, permissions and late-receipt guards stay intact.
Base: #3054 is merged as
54e4c0a86fb77eabba73b5d21557d6f8720571bd, and this PR is retargeted to main with that merge integrated. The delivered base has the same tree as reviewed parent28c4f49de; the pending-ownership source diff is unchanged. The new head records the estimate closeout and reruns hosted qualification against main. Child #3064 remains based on this branch, so preserve the branch until that child is retargeted.Validation:
fc7cbb948b1c3e9dce3ad19bb8dc4f790930202b.git diff --checkpass. Exact-head hosted qualification remains required.The earlier focus rescue and mounted late-failure receipt shipped in #3050. Successful settlement may leave a returned card's selected snapshot stale after the original child unmounts; this separate MEDIUM behavior is tracked in #3060. A redundant stale request is rejected by the server version check before mutation. Request ownership remains editor-instance scoped; independent tabs retain server concurrency protection.
Physical-device and screen-reader checks remain open in
OUTSTANDING_TASKS.md. Evidence is preserved locally underC:/td0912-evidence/archive-request-ownership; traces and generated operational material are not public artifacts.Closes #3033