Keep archive draft settlement and lifecycle controls consistent - #3064
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c6ee911e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Merged as9a8c14c6bd385f5607633462060f9d11fc57c05a after exact-head required run34716287296 passed at13dfde5ca3459e9ab8c420c84c91557bf1af6cb5 against main44d041ca7, including Windows API and E2E. The first post-merge check is clear; this PR is DonePriorityIV. Issue #3023 remains open with its separate recovery-copy and broader residuals, and #3060 remains separate. No release or human acceptance is inferred. |
|
Finished worktree cleanup: source13dfde5ca is preserved in delivered main9a8c14c6b, tracked/untracked status was clean, and the only ignored files were rebuildable dist/node_modules. Plain git worktree remove completed. No untracked QA artifacts needed copying; inventory/ancestry receipt remains at C:/td0912-evidence/delivered-archive-draft. |
1 participant
If an archive finished while an assignment save was pending, the editor retained its unsaved-draft notice after the save made the draft clean. Restore could then become available with the frozen pre-archive version and immediately fail with a conflict.
Show the notice only while a draft remains and keep lifecycle actions disabled until the editor is reopened after an archive completed over a draft. The draft and pending-request ownership protections remain intact.
Validation: the deferred archive-then-assignment regression fails before the fix; all 108 related component tests, frontend lint, TypeScript checking and production build pass afterward. Independent review found no causal HIGH blocker. Parent #3059 merged as44d041ca7 and this PR is retargeted to main. The delivered base has the same tree as its reviewed parent; the runtime correction remains confined to CardModal and its assignment-save host spec. The final head records archive delivery and must pass hosted qualification against main.
Refs #3023. Its recovery-copy follow-up remains open: a clean draft should leave explicit reopen guidance while Restore stays frozen. Comment-cache/delete-confirmation cases and #3060 remain separate. Existing physical-device and screen-reader actions in OUTSTANDING_TASKS.md are unchanged.