Show relation-specific navigation guidance while proposals are pending - #3087
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Chris0Jeky
left a comment
Chris0Jeky
left a comment
There was a problem hiding this comment.
Independent Terra review: CLEAN. Reviewed the four-file source at base 96f4b7c; working diff hash d4dc741ff2cc88127e3ecd3f4d553b0cbb9ce8e1. Relation activity uses a separate event channel, remains in the leave predicate, and displays proposal-specific guidance. Private-answer, recording and companion-send guards retain their precedence and behavior. No HIGH/CRITICAL or lower-severity finding was raised. Reviewer did not rerun tests.
Coordinator verification: all four committed source blobs match 736f0b7 at published fd221ba after incorporating main2cdc45257. Full frontend: 6,911 passed, 3 existing skips; build/typecheck and lint pass. Evidence is retained under C:/td0912-evidence/3077-navigation-guidance. Hosted required qualification is pending.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd221ba58a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Chris0Jeky
left a comment
Chris0Jeky
left a comment
There was a problem hiding this comment.
Fresh-context review: no merge-blocking state-ownership or navigation-guard finding on this head.
Splitting relation-busy from private-answer busy is the correct boundary: the workspace still treats both as leave-blocking activity, but can present channel-specific instructions instead of mislabeling a relation request as recording or private-answer work. Route changes reset both states, the leave action refuses all three in-flight channels, and ordinary draft/companion behavior is preserved.
Exact-head Required CI, CI Extended and Smart CI are completed successfully. One wording residual remains exactly as already recorded: this parent says approval but omits the separate Apply action. Stacked PR #3096 has the focused red/green correction and should be retargeted/merged immediately after this parent; I found no reason to redesign the guard itself.
1 participant
Leaving the thinking workspace while a relation proposal request was pending showed private-answer or recording instructions. The deck now reports relation activity separately, and the workspace keeps its leave guard with guidance that accurately describes the pending proposal. Private-answer, recording and companion-send behavior is preserved; relation changes still require review and Apply.
The four-file source commit 736f0b7 is preserved and its blobs match after incorporating delivered main 2cdc452. One independent Terra review found no correctness or authority blocker. The two progress records include the navigation candidate and delivered archive settlement; the latter's MEDIUM form-version follow-up remains #3083.
Validation: 20 focused tests pass. The full frontend suite passes 6,911 tests with three existing skips across 445 files; production build (including vue-tsc) and full lint pass with ten existing warnings. Documentation links, docs governance, operations governance and diff checks pass. The full-suite runtime tree 5004e6e is unchanged by the documentation commit. Exact-head/base ci-required.yml remains required before merge. No new manual browser or physical-device acceptance is claimed. Existing human actions remain unchanged.
Closes #3077
The bounded connector triage identified a MEDIUM copy omission: the pending navigation sentence mentions approval but omits the separate Apply step. This is tracked in #3088 with focused acceptance. The pending guard and approval/Apply behavior are unchanged; no copy correction is claimed in this PR.