Name Apply in relation proposal navigation guidance - #3096
Conversation
Chris0Jeky
left a comment
Chris0Jeky
left a comment
There was a problem hiding this comment.
Fresh-context review: no blocker on this stacked correction.
The new sentence accurately states the full authority sequence—wait for proposal creation, approve it in Review, then choose Apply—without implying that approval itself mutates the board. The focused test is load-bearing: it failed against the parent copy and passes on this exact head. No guard, routing, proposal, approval, Apply, or server behavior changes.
Smart CI and Extended CI are successful, and all 17 Required CI child jobs are terminal-success despite the parent workflow record's finalization lag. Keep this PR draft only until #3087 merges; then retarget to main, confirm the diff remains the one sentence plus regression, and mark ready.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Purpose
The relation-pending leave dialog introduced by #3087 explains approval but omits the separate Apply action. This stacked follow-up keeps the existing navigation lock and review-first behavior, while making the copy describe the full user contract: approve in Review, then choose Apply.
Red → green evidence
RED — proven before production changed. Commit
59c39df129a6cb18dd617174f333cd9722f64ab4changed only the focused continuity regression. CI run34911337614, Ubuntu frontend job104199332203, passed lint, typecheck, build, and PWA validation, then failed in Run frontend tests with coverage thresholds because the relation-only dialog did not contain the required Apply sentence.GREEN — exact hosted head. Commit
49adb692d95a13beae654828bb5e50fc639e661fchanges one production sentence to satisfy that assertion.34911841112: success.34911841287: success.34911841302: all 17/17 jobs are terminal with no failure, queued, in-progress, or null-conclusion job. The GitHub Actions parent run still reportsin_progress, which is workflow-finalization/API lag rather than an executing or failed job.Scope
Closes #3088