Refresh CardModal fallback height on window resize - #3104
Open
Chris0Jeky wants to merge 2 commits into
Open
Chris0Jeky wants to merge 2 commits into
Chris0Jeky wants to merge 2 commits into
Conversation
Chris0Jeky
marked this pull request as ready for review
September 15, 2026 01:38
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #1739's no-
VisualViewportpath.CardModaldeliberately uses the composable'slayoutfallback, but that fallback sampledwindow.innerHeightonly once. A resize or orientation change could therefore leave an open modal at stale geometry and clip its actions.The implementation observes
window.resizeonly whenVisualViewportis unavailable and the caller selected thelayoutfallback. The existingVisualViewportresize/scroll path and theunset/100dvhdialog fallback are unchanged.Red → green evidence
RED — exact test-only head. Commit
351ae44a7c87dc7b5ca57e6c0a27d570537b1a9dadded onlyuseVisualViewportFallbackResize.spec.ts. CI run34915717641, Ubuntu frontend job104212818008, passed lint, typecheck, production build, and PWA validation, then failed the frontend test phase. Its archived JUnit receipt reports exactly one failure:useVisualViewport layout fallback resize > tracks window resize without VisualViewport and removes the fallback listener on unmountexpected undefined to be definedwindow.resizelistener was registered.GREEN — exact hosted head. Commit
f3ae80bb2d09042e93a02fea5f945a0b9098b359adds the narrow fallback listener and symmetric cleanup.34916091226: success.34916091593: success.34916091523: success.Scope
VisualViewportresize/scroll path and theunset/100dvhdialog fallback remain unchanged.Closes #1739