Repository navigation
chore: pin core#93, and prove ! A, B end to end - #67
Merged
Merged
Conversation
Step 4 of the core#93 cascade — all four pins move together, since the CLI has no `[patch]` to unify them and a split graph gives two incompatible `FrozenUnit` types. `comline-codegen` is pinned at the rev *both generators* pin, not at generation's branch tip. The end-to-end test needed real work, not just a rev bump. It builds a generated crate against the runtime and round-trips it, so it is the only place the whole chain is exercised: the real binary parses the schema, generates the crate, and the crate talks to the runtime. The fixture schema now declares two errors and `! Rejected, TooLong`, which is the first time multi-`!` is parsed by the actual binary rather than by a hand-built IR fixture. The driver covers: - a declared error (`Fault::App`), decoded back into its own variant - the *second* error of the two, decoded into its own variant and not into whichever shares an ordinal - `Display` from the schema's `message` template, both plain (`"rejected: empty"`) and interpolated (`"too long: 8 max"`) - an undeclared failure as `Fault::Internal`, arriving as `CallError::Runtime(RuntimeError::Provider)` - that the connection survives a fault — it is a reply, not a teardown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 4 of the core#93 cascade. All four pins move together —
clihas no[patch]unifying them, so a partial bump gives it twocomline-corecopiesand two incompatible
FrozenUnittypes.comline-codegenis pinned at the revboth generators pin (
f919acf), not at generation's branch tip, which is themistake a previous run of this cascade made.
The end-to-end test needed real work
It is the only test anywhere that drives the whole chain: the real binary
parses a schema, generates a crate, and that crate is compiled against
comline-runtimeand round-tripped. So it is where the error-handling workactually gets proven, and the rev bump broke it exactly as expected — the
hand-written provider returned
Result<_, ChatSendError>where the trait nowwants
Fault<ChatSendError>.The fixture schema now declares two errors and
! Rejected, TooLong. This isthe first time multi-
!is parsed by the actual binary rather than by ahand-built IR fixture — core#93's grammar change had until now only been
exercised by core's own tests.
The driver covers:
Fault::App) decoded back into its own variantwhichever happens to share an ordinal
Displayrendered from the schema'smessage, plain ("rejected: empty")and interpolated (
"too long: 8 max")Fault::Internal, surfacing asCallError::Runtime(RuntimeError::Provider)— the escape hatch that did notexist before
Verification
92 tests pass, 0 failed. fmt clean.
Note the checkout has an unrelated uncommitted edit to
src/commands/new.rsthat is not mine; it is deliberately not part of this commit.
Ordering
playgroundis the last step and follows this one.