Repository navigation
conformance: goldens for the default connection and the lockstep framing - #154
Merged
Merged
Conversation
added 3 commits
November 15, 2026 21:54
…gram framing connections_default: a server-provided and a client-provided protocol on datagram@3 + comline@2, the defaults core writes into a protocol, so Services, ClientServices, HELLO/handshake() and both senders are pinned. lockstep: a protocol on the unversioned datagram framing, which gets a Dispatcher and a Client: a struct return that throws, an array return and a one-way function. Only new goldens; no existing golden changes.
send_message (with @timeout_ms, throwing RecipientNotFound) and fetch_inbox, so the call_with_timeout path is pinned and the fixture matches the docs.
…is the one the docs show
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two conformance fixtures and their goldens for cases no golden covers today. Tests only: no existing golden changes.
The two cases
connections_default: a package with a server-provided protocol (Chat) and a client-provided one (Events,@provider = Client, with a one-way functionping), both ondatagram@3+comline@2. PinsServices,ClientServices,HELLO/handshake()and both senders (ChatSender,EventsSender) in Rust and TypeScript. The fixture states the defaults as explicitframing/handshakeproperties on each protocol, which is what core freezes into the IR when a package says nothing (the same waydefaulted_protocoldoes), so the fixture model has no separate "default" form.lockstep: the Protocols guide'sMail(send_messagewith@timeout_ms = 1000, returning a string and throwingRecipientNotFound;fetch_inboxreturningMessage[]) on the unversioneddatagramframing, which getsMailDispatcher/MailClientinstead of connection-levelServices. It pins thecall_with_timeoutpath too.Why
I checked every golden under
conformance/tests/golden/:ClientServicesunder the defaultsdatagram@3+comline@2.handshake_comline2,nested_protocolanddependency_and_own_protocolsare server-only, andconnectionspinsdatagram@2/comline@1.datagramframing'sDispatcher/Client; onlyframing_jsonrpchas a Client/Server pair.The first case is the default one and is about to change: generation#153 (Hello entries per protocol) and comline-rust#133 (subset
Services/ClientServices). The golden has to exist first so that change shows up as a diff in its own PR.What changes
New fixtures
connections_defaultandlockstepinconformance/src/lib.rs, their goldens (blessed withCONFORMANCE_BLESS=1 cargo test -p comline-conformanceagainst the pinned generators), and the regeneratedFEATURES.md/features.json(the "proven by" lists now include the new fixtures). No existing golden file is touched.