Skip to content

conformance: goldens for the default connection and the lockstep framing - #154

Merged
Kinflou merged 3 commits into
masterfrom
conformance/default-and-lockstep-goldens
Nov 15, 2026
Merged

Kinflou merged 3 commits into
masterfrom
conformance/default-and-lockstep-goldens

Conversation

@Kinflou

@Kinflou Kinflou commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Adds two conformance fixtures and their goldens for cases no golden covers today. Tests only: no existing golden changes.

The two cases

  • connections_default: a package with a server-provided protocol (Chat) and a client-provided one (Events, @provider = Client, with a one-way function ping), both on datagram@3 + comline@2. Pins Services, ClientServices, HELLO / handshake() and both senders (ChatSender, EventsSender) in Rust and TypeScript. The fixture states the defaults as explicit framing / handshake properties on each protocol, which is what core freezes into the IR when a package says nothing (the same way defaulted_protocol does), so the fixture model has no separate "default" form.
  • lockstep: the Protocols guide's Mail (send_message with @timeout_ms = 1000, returning a string and throwing RecipientNotFound; fetch_inbox returning Message[]) on the unversioned datagram framing, which gets MailDispatcher / MailClient instead of connection-level Services. It pins the call_with_timeout path too.

Why

I checked every golden under conformance/tests/golden/:

  • None has ClientServices under the defaults datagram@3 + comline@2. handshake_comline2, nested_protocol and dependency_and_own_protocols are server-only, and connections pins datagram@2 / comline@1.
  • None covers the lockstep datagram framing's Dispatcher / Client; only framing_jsonrpc has a Client/Server pair.

The first case is the default one and is about to change: generation#153 (Hello entries per protocol) and comline-rust#133 (subset Services / ClientServices). The golden has to exist first so that change shows up as a diff in its own PR.

What changes

New fixtures connections_default and lockstep in conformance/src/lib.rs, their goldens (blessed with CONFORMANCE_BLESS=1 cargo test -p comline-conformance against the pinned generators), and the regenerated FEATURES.md / features.json (the "proven by" lists now include the new fixtures). No existing golden file is touched.

Kinflou added 3 commits November 15, 2026 21:54
…gram framing

connections_default: a server-provided and a client-provided protocol on
datagram@3 + comline@2, the defaults core writes into a protocol, so
Services, ClientServices, HELLO/handshake() and both senders are pinned.

lockstep: a protocol on the unversioned datagram framing, which gets a
Dispatcher and a Client: a struct return that throws, an array return and
a one-way function.

Only new goldens; no existing golden changes.
send_message (with @timeout_ms, throwing RecipientNotFound) and fetch_inbox,
so the call_with_timeout path is pinned and the fixture matches the docs.
@Kinflou
Kinflou marked this pull request as ready for review November 15, 2026 14:15
@Kinflou
Kinflou merged commit 5edd49f into master Nov 15, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant