fix(dossier): address the schemas by slug — all five lookups 404'd - #622
Merged
Conversation
OpenRegister resolves a schema identifier by slugifying it and matching the
slug. `DossierNote` slugifies to `dossiernote`; the declared slug is
`dossier-note`. All five schemas PupilDossierTimelineView loads are
multi-word, so all five 404'd and loadAll() could never populate a timeline
for any learner.
Measured against a live instance:
.../objects/learniq/DossierNote -> 404
.../objects/learniq/dossier-note -> 200
.../objects/learniq/BehaviourIncident -> 404
.../objects/learniq/behaviour-incident -> 200
and all five corrected slugs return 200.
A single-word title hides this — `Course` slugifies to `course` and happens
to resolve — which is why the same pattern reads as fine elsewhere.
ExamCaseDossierView already carries this warning after the identical bug was
found there; this is the same defect in the view nobody had reached yet.
Found via learniq#620: the e2e failure that #618 deliberately left loud was
a true report, and this is what it was reporting. Not the register-seeding
fault I first attributed it to.
Contributor
Quality Report — ConductionNL/learniq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 650/650 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-26 14:38 UTC
Download the full PDF report from the workflow artifacts.
This was referenced Aug 26, 2026
Contributor
Quality Report — ConductionNL/learniq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 650/650 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-26 22:49 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last e2e failure on
development, and it was not what I first said it was.The bug
OpenRegister resolves a schema identifier by slugifying it and matching the slug.
DossierNoteslugifies todossiernote; the declared slug isdossier-note.Every one of the five schemas
PupilDossierTimelineView.loadAll()requests is multi-word, so every one of them 404'd. The timeline could never populate for any learner.Measured against a live instance:
.../objects/learniq/DossierNote.../objects/learniq/dossier-note.../objects/learniq/BehaviourIncident.../objects/learniq/behaviour-incidentAll five corrected slugs verified
200.Why it looks fine elsewhere
A single-word title hides it.
Courseslugifies tocourseand happens to resolve, so the same PascalCase pattern reads as correct throughout the app. It only breaks where a title has two words.A sweep of
src/found six such names. Five are here; the sixth isExemptionCaseinExamCaseDossierView, which is already fixed — that view carries a detailed warning from when the identical bug was found there, with the same live measurements:This is that same defect in the one view nobody had reached yet. The warning is now repeated here so the next person does not have to rediscover it a third time.
How it surfaced, and a correction
#610 made the e2e suite navigate honestly. #618 then quieted 404s in three views but deliberately left
PupilDossierTimelineViewloud, because its calls are list queries where absence is200+[]and a 404 means the schema did not resolve.That decision is what found this. The remaining failure was a true report, and this is what it was reporting.
I initially mis-attributed it in #620 to the
learniqregister being absent during seeding, based on[RegisterMapper] Register does not exist … identifier=learniqin the CI server log. That log line is real, but it is a separate seed-time event and not the cause of this 404. #620 is corrected accordingly.Verification
node --checkon the extracted<script>block, and all five slugs confirmed200against a running instance before committing.