Repository navigation
Bound mat carbon models, conditional floc assembly and Naica physiology (batch76) - #1636
realmarcin wants to merge 1 commit into
Conversation
realmarcin
left a comment
There was a problem hiding this comment.
Source-based self-adversarial review at exact head a74e8e8; not independent approval.
Repairs #1632-#1634 addressed; non-graph #1635 unresolved.
-
Preserve measured diel expression, not metabolic flux or demonstrated niche partitioning.; Retain proposed polymer-to-photomixotrophy link as HYPOTHESIZED.; Bound diazotrophic potential and partial-genome absence; replace unsupported directional taxa with participants.; Preserve uneven overlapping mat structure; remove spatial-context arrow.
-
Preserve microcolonies and their conditional contribution to mixed structures.; Preserve actual macroclusters with centrifugation/calcium and imaging boundaries; remove model-utility arrow.; Retain proof-of-concept utility without a second biological causal stage.
-
Preserve aggregate NDC-6 removal and functional complementation; no mutualism, invented intermember flux, or new arrow. Existing1197/1198 boundaries between three-day10C performance and separate10.2C optimization remain unchanged.
-
Retain lineage-specific inferred thermophily; remove environmental-context arrow.; Retain putative oxidation; correct GO grounding and remove unmeasured graph concentrations.; Retain proposed donor constraint with negative-PCR limits; remove co-occurrence arrow and unsupported competition.
-
All four whole records and every original node/arrow reviewed after fresh both-root baseline. Three complete main bodies plus tables/captions; two abstract-bounded sources and only partial indexed diel Methods. Access errors and subscription barriers respected, not bypassed. No claim that unseen controls are absent.
-
Retain measured Mushroom Spring RNA patterns. The metabolic endpoint remains putative carbon fixation so the polymer-reserve arrow does not spuriously become a cause of gene expression. This intermediate self-review finding was corrected, and complete verification rerun with superseded outputs preserved. Polymer flux is the explicit source model, not a measured flux assay.
-
Thermodesulfovibrio nitrogen fixation is putative even with accessory nif genes; prior Synechococcus activity is not transferred to it. Remove source/target implication and preserve canonical participants. Partial genomes limit absence conclusions; mat layers overlap and distinct sampling campaigns are not a simultaneous intervention. Remove spatial restatement arrow without discarding measured community structure.
-
Preserve real stable nitrifier microcolonies and mixed macroclusters. Release alone did not suffice; centrifugation plus calcium-rich resuspension and their unresolved separation are explicit. FISH-induced aggregation is a separate artefact, not a reason to deny later suspended clusters. Remove only the model-utility causal stage, not biological assembly.
-
NDC6 is valid unchanged: measured aggregate low-temperature removal and functional complementation need no arbitrary arrow. Preserve1197/1198 no-mutualism and optimization-versus-three-day boundaries. Do not falsely recast reported gene-expression evidence as metagenomics or assert unmeasured per-member fitness.
-
Naica thermophily is inferred from high GC in specified lineages, not universal OP3 growth measurements. AamoA detection supports putative oxidation but not flux or concentrations. Correct assimilation GO0019676 to oxidation GO0019329, verified against AmiGO, without taxonomy changes.
-
Negative dsrA amplification does not establish absence. Preserve proposed donor scarcity and non-dominance interpretation with sampling/primer limits, unpublished H2S context and no claimed donor-rescue assay. Neither environmental context nor co-occurrence with AamoA creates a causal link. Unsupported competition label and two context arrows removed.
-
Three case-inexact graph quotations corrected and the truncated negative-PCR quote shortened; all18 graph quotes match both fresh source and cache. Original erroneous cache-suffix search is not evidence of absence.920 caches and all raw non-graph blocks remain untouched; residual metadata claims tracked separately in1635.
-
Every11 nodes and6 original arrows accounted for;11nodes2arrows remain. Three guarded writes and histories;457 records including NDC6 unchanged. Zero structural defects and44 baseline warnings unchanged. Connectivity census unchanged, not evidence of member-level effects.
-
Actual schema, strict, terms, full-record references, snippets, histories, both-root inventory/network/rank, regression, lint and deterministic rendering checks retained. Exact descriptions parsed across456 generated pages, not browser screenshots. Postcommit docs-current is separate.
-
No new topology or paid provider call. Earlier Edison authorization scopes are unchanged.916 issue bodies and27 ignored/hidden local matches deduplicated;1197/1198/939/396 preserved. No exhaustive PR-comment audit.1632-1634 stay OPEN until protected-main merge;1635 stays OPEN afterward. Self-review is not independent approval or corpus completion.
677 passed in 244.49s (0:04:04); eight new focused tests. Schema, strict, terms, full-record references and snippets passed for all four records; all three histories passed. All four full-record reference validators exit0. CLI Total checks counts issues, not executed checks. All18 graph quotations independently match fresh primary XML/abstract and existing caches. Cache matching is not entailment. Diel and NDC sources remain abstract-bounded; all920 caches unchanged, not recertified. Prior batch73 non-graph reference exception is outside this batch.
All11 original nodes and6 arrows reviewed;11 nodes and2 arrows retained. Three records repaired; NDC6 unchanged. Measured RNA, uneven overlapping mat populations, stable microcolonies and true mixed macroclusters remain. Polymer-to-putative-fixation link retained without implying a cause of gene expression. No new structure or paid provider run. Non-graph #1635 stays OPEN.
All457 unchanged records,920 caches and raw non-graph blocks verified. Canonical taxa and auditor rules unchanged. Zero structural defects;44 baseline warnings preserved exactly; connectivity census unchanged. Repeat renders deterministic, exact descriptions parsed across456 pages, not browser screenshots.
Postcommit just check-docs-current passed with clean tree; log SHA256 fd9022806e955b1ecad52f6d69f2e52de1df97035302940c33543cdd05bf979f. Every-node/every-arrow decisions,39 final actual check outputs/digests and self-adversarial review committed under reports/causal_graph_review, batch76. Initial validation outputs preserved as superseded after correcting an intermediate endpoint rename. Final focused rerun:17 passed. Corpus:246 reviewed,188 pending,26 needs_research. Not independent approval or corpus completion.
Protected-main merge pending.
Network integrity findingsWarnings only — a member with no interaction yet, or a participant matched by ontology id rather than by name, or one on a community-level interaction that resolves to no member. Reported, but does not fail the build. The full report is attached to the workflow run as an artifact. |
3a00e0c to
c8f0d6f
Compare
a74e8e8 to
85a1a7b
Compare
realmarcin
left a comment
There was a problem hiding this comment.
Self-adversarial integration review at exact head 85a1a7b0b52f7779d17aabeddcac57037dcf4a9d. Not independent approval.
Integrated already-merged schema prerequisite #1692 (67603e192525899fae75420e2c19e8212b16afc9). Compared with the prior reviewed head a74e8e81dc708280fedbf1fe63453275b3d53394, the only changes are the canonical schema pin, shared schema and generated datamodel from that main commit. Every other tracked file is identical; the batch-owned binary patch remains byte-identical (SHA-256 ddc201330bd56eef86f378fc07322be51883e4fb15222e7e1dda4ccd901557a7). All 60 published batch patches were checked this way. No scientific assertion, reference cache, history, decision ledger or generated page was edited by this integration.
Adversarial checks: no inherited schema-file edits lost; generated CrossCorpusLink remains standalone and does not add a causal claim; normal strict validation passed all 460 records; required CrossCorpusLink fields enforced. Fresh broad regression runs on both ends of the stack: 302 passed in 172.77s (0:02:52); 756 passed in 255.55s (0:04:15). Docs-current passed clean at batches25/84, and vendored-sync passed. The 58 intermediate combinations were not independently retested. Existing primary-source review limitations and unresolved research issues remain applicable; historic validation receipts are not rewritten as new scientific reviews.
An additional generated-datamodel loading check FAILED and is retained in the integration receipt. Differential testing found exactly the same failures on all 460 paths before and after this integration:417 unhashable TaxonDescriptor and43 unhashable CultureCollectionEnum exceptions, with linkml-runtime1.11.1. Existing tests explicitly use plain YAML instead of this loader. Pre-existing defect #1703 remains OPEN; no datamodel-loader success is claimed. Normal strict schema validation is a separate passing path, not a relabeling of that failure.
Required CI must pass on this exact head and the protected merge-queue candidate. No manual workflow dispatch, artificial status, administrative merge or protection bypass. Dependents stay draft until their parent is confirmed merged; move dependents before branch deletion.
c8f0d6f to
baa1abe
Compare
85a1a7b to
4357c2a
Compare
realmarcin
left a comment
There was a problem hiding this comment.
Self-adversarial review refreshed at exact head 4357c2a0a3649cfc1a7cba3164a2af34c04e98ca
after protected main merge of #1361. This is not independent approval.
The entire tree remains identical to the preceding reviewed tree dcbcdececc216d6adcc05ebedde18ab59c489abc.
The batch-owned binary patch is byte-identical
(SHA-256 ddc201330bd56eef86f378fc07322be51883e4fb15222e7e1dda4ccd901557a7); only ancestry changed.
Scientific records, caches, source-review output, histories, regression tests, and generated pages
are unchanged. Historical validation results and recorded source/access limitations therefore
remain applicable, but required CI must pass at this new head. No new source review or local test
rerun is claimed by this ancestry-only update.
The protected main queue remains mandatory. Keep dependents on their reviewed parent until that
parent is confirmed merged; move dependents before deleting merged branches.
4357c2a to
6c3dee2
Compare
realmarcin
left a comment
There was a problem hiding this comment.
Self-adversarial governance integration review at exact head 6c3dee20c873b175f43ede45babbcff53814f8b7. This is a COMMENT, not independent approval.
Integrated already-merged main PR #1730 (fe1752572a688051e8105e5b89d3099fe2202c63). Compared with prior reviewed head 4357c2a0a3649cfc1a7cba3164a2af34c04e98ca, exactly two files changed: scripts/.vendored_canon_ref and tests/test_id_label_empty_adapter.py. Each resulting tree differs from its old tree by the exact binary patch from main, and each batch-owned binary patch remains byte-identical (SHA-256 ddc201330bd56eef86f378fc07322be51883e4fb15222e7e1dda4ccd901557a7). These invariants passed on all 74 published branches. Original heads are retained in local archive refs/archive/communitymech-pre-governance-20261007. No scientific record, source cache, history, decision ledger, schema, runtime code or generated page changed in this integration.
Adversarial inspection: the adapter regression still checks the empty sentinel and case-insensitive caching, now with an isolated fake oaklib module and a one-call selector assertion. No validation threshold or runtime behavior was relaxed. Fresh regressions at both stack ends: 337 passed in 214.19s (0:03:34); 917 passed in 402.58s (0:06:42). Docs-current and pinned vendored-sync passed at batches26/99. The 72 intermediate combinations were checked by tree/patch hashes, not independently retested. Historical source-review limitations and unresolved issues, including loader #1703 and cache #1091, remain applicable. This is not new paper review, independent approval, or a claim that those outstanding issues are fixed.
Digest-bound integration receipt/logs: /private/tmp/communitymech-governance-integration-20261007/receipt.json. Prior output/review records in reports/causal_graph_review/ remain unchanged. The prior lifecycle receipt is archived and will be updated only after all exact-head comments are verified.
Required CI and independent review must pass for the exact head and protected merge-queue candidate. No CI rerun, manual dispatch, fabricated status, admin merge or protection bypass. Dependents remain draft; move them before deleting a merged parent branch.
38a02bb to
dcac22b
Compare
6c3dee2 to
7d579b7
Compare
realmarcin
left a comment
There was a problem hiding this comment.
Exact-head self-adversarial restack review at 7d579b724265208e0b5e8efe40ce835143d86d69.
COMMENT, not independent approval.
The batch-owned binary patch remains byte-identical:
SHA-256 ddc201330bd56eef86f378fc07322be51883e4fb15222e7e1dda4ccd901557a7.
Tree a82606d6b95edc0be5f679d3d2c936c0e9a8f04f matches the independently computed clean merge.
Compared with historical tree e0bb46749b05ae321bd90b980aa420211c90e8d2, only scripts/.vendored_canon_ref
changes, incorporating main PR #1834's pin 849f336e025510316a5f235eb0af8547b8bd50cc.
All curated records, source caches, review outputs, histories, regression tests, and rendered
pages remain unchanged. No new primary-source review or local scientific-test rerun is claimed.
This PR is now part of native stack #1973, rooted at #1363 on main. No protected merge
has occurred. Fresh eligible PR/merge-group CI remains mandatory. No rule bypass, fabricated
status, merge into a topic parent, or premature branch deletion.
7d579b7 to
d6016b3
Compare
|
Superseded by the protected cumulative merge #1975 at Patch-inclusion receipt. Existing issue-closing links were transferred to #1975; unresolved research and non-graph gaps are not closed by this action. This PR is being closed as superseded, not represented as individually merged. Archival provenance tags retain source commits; cleanup removes branch refs only and preserves worktree files. |
Scope
Closes #1632.
Closes #1633.
Closes #1634.
Non-graph #1635 stays OPEN after graph-repair merge.
Adversarial Review
Verification And Output Records
677 passed in 244.49s (0:04:04); eight new focused tests. Schema, strict, terms, full-record references and snippets passed for all four records; all three histories passed. All four full-record reference validators exit0. CLI Total checks counts issues, not executed checks. All18 graph quotations independently match fresh primary XML/abstract and existing caches. Cache matching is not entailment. Diel and NDC sources remain abstract-bounded; all920 caches unchanged, not recertified. Prior batch73 non-graph reference exception is outside this batch.
All11 original nodes and6 arrows reviewed;11 nodes and2 arrows retained. Three records repaired; NDC6 unchanged. Measured RNA, uneven overlapping mat populations, stable microcolonies and true mixed macroclusters remain. Polymer-to-putative-fixation link retained without implying a cause of gene expression. No new structure or paid provider run. Non-graph #1635 stays OPEN.
All457 unchanged records,920 caches and raw non-graph blocks verified. Canonical taxa and auditor rules unchanged. Zero structural defects;44 baseline warnings preserved exactly; connectivity census unchanged. Repeat renders deterministic, exact descriptions parsed across456 pages, not browser screenshots.
Postcommit just check-docs-current passed with clean tree; log SHA256 fd9022806e955b1ecad52f6d69f2e52de1df97035302940c33543cdd05bf979f. Every-node/every-arrow decisions,39 final actual check outputs/digests and self-adversarial review committed under reports/causal_graph_review, batch76. Initial validation outputs preserved as superseded after correcting an intermediate endpoint rename. Final focused rerun:17 passed. Corpus:246 reviewed,188 pending,26 needs_research. Not independent approval or corpus completion.
Source Limits
Dependency
Draft depends on #1631. Do not merge into the topic parent. Require eligible exact-head CI and protected main queue after the parent merges. Move dependents before deleting parent branches.