Skip to content

fix(exec): bound recount and ordered traversal work - #1124

Merged
DecisionNerd merged 3 commits into
mainfrom
fix/1119-bounded-recount-ordered-hop
Sep 5, 2026
Merged

DecisionNerd merged 3 commits into
mainfrom
fix/1119-bounded-recount-ordered-hop

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Unconstrained relationship recount now reads authenticated adjacency cardinality, and eligible ordered destination-UUID LIMIT queries stop after the required results. One- and two-hop shortcuts require a complete frontier and authenticated UUID ordering; constrained and nonmonotonic cases retain ordinary execution. Preserve aliases, bound identity lookups and sharded adjacency reads, and report actual optimized operator RSS/work.

The ladder validator now recognizes the actual optimized leaf evidence: the exact operator family and RSS record, no Arrow input batches, positive identity I/O, bounded destination probes/candidates, and no materializing reads. One-hop cardinality is exactly min(LIMIT, reopened live edges), with direct result checks and under-/over-emission negatives. Existing streaming and Expand evidence retain their own bounded checks. No thresholds, timeouts, assertions, or host qualification requirements are relaxed.

Validation on current main plus this change (isolated native target, four build jobs, ext4 TMPDIR):

  • Full real-facade fixed_hop_limit suite: 17 passed, 2 unchanged release-only benchmarks ignored; 1334.27s. Covers ordinary two-partition counts, NULL/restricted/undirected semantics, nonmonotonic UUID ordering, aliases, 65,537-destination chunking, huge LIMIT, 1x/2x sharded hubs, hydration and graph-growth bounds.
  • Full scale_g500_ladder suite: 26 passed in 188.12s. Includes the three previously failing CI cases and adversarial optimized-evidence validation.
  • Storage ordinal identity: 25 passed; shard boundary/corruption: 2 passed; demand accounting: 13 passed; aggregation: 3 passed.
  • Workspace Clippy -D warnings, fast checks, 14 gate-registry tests, final formatting and diff checks: passed.
  • Extra Clippy on the entire ladder test target reports eight pre-existing warnings in unchanged code; the pre-edit file reproduces the identical eight warnings. Required workspace Clippy is green.

The certifier receipt contract now includes the numeric adjacency-probe field and preserves full query evidence while continuing to reject missing, malformed, or unexpected fields. The independently verified workflow failure-propagation fix (#1126/#1125) is merged into this base.

Final integration on 6a937da07a6ee9eb5ae5b2b4247f7432a5e7211a retained the engine and ladder-validator patches unchanged by range-diff. make -C benchmarks smoke passed all 386 Python tests and Rust runners (26 certifier tests), workspace Clippy/formatting, and the actual Cargo boundary check. Certifier all-targets Clippy passed. Fresh CLI and all benchmark binaries completed the real ten-phase tiny lifecycle with 2 recount, 2 query, and 4 reopened-query receipts and matching source/imported results. Final fast/gate/format/diff checks passed.

Canonical #1094 remains open for integrated OVHC-AGENCY S18/S19 plateau and S20 admission/completion or next typed failure. These are GraphForge lifecycle measurements using Graph500-compliant generated input, not official Graph500 performance results. This PR supplies the existing #1116/#1079 prerequisite; lifecycle accounting remains there.

Closes #1119. Exact-head CI run 33951664925 passed at e838eafa5ae458a267c6f7820de8a69d34f1de28, with successful CI Gate, CLEAN merge state, and no unresolved review threads. Squash merged as 27673a642ad2bb0cd660a2a1fa8cf831cf2a419d; issue #1119 is closed.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: f753a119-239d-465c-a7c2-6d26430f3d59

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added planner Changes to query planner executor Changes to query executor core Core source code changes labels Sep 5, 2026
@blacksmith-sh

This comment has been minimized.

@DecisionNerd
DecisionNerd force-pushed the fix/1119-bounded-recount-ordered-hop branch from a2f50f1 to e838eaf Compare September 5, 2026 07:07
@DecisionNerd
DecisionNerd marked this pull request as ready for review September 5, 2026 07:07
@DecisionNerd
DecisionNerd merged commit 27673a6 into main Sep 5, 2026
21 checks passed
@DecisionNerd
DecisionNerd deleted the fix/1119-bounded-recount-ordered-hop branch September 5, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core source code changes executor Changes to query executor planner Changes to query planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(exec): bound recount and ordered traversal work

2 participants