fix(bench): preserve workflow receipt failures - #1126
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
A public-command workflow could report success after a child exited zero with an invalid JSON receipt: the child execution carried
EvidenceInvalid, but workflow aggregation checked only the exit code and continued. Stop on either a nonzero exit or a recorded execution failure, preserving the original exit code, failure classification, prior receipts, cleanup details, timing, and RSS.A real child-process regression proves valid zero-exit receipt sequences succeed, while an invalid second receipt stops the workflow after exactly two commands and retains only the preceding valid receipt. It failed before the fix (
Noneinstead ofEvidenceInvalid) and passes afterward. Existing nonzero-exit handling remains covered.Validation:
-D warningspassed.This is the independent gate defect blocking #1119/#1124. Updating the new adjacency-probe receipt field remains in #1124; this change does not relax receipt validation or resource thresholds.
Closes #1125. Exact-head CI run 33950728612 passed at
78f76ee3bb28d02aae82b6c8829a3d9f2b7f5a88, with successful CI Gate, CLEAN merge state, and no unresolved review threads. Squash merged as6a937da07a6ee9eb5ae5b2b4247f7432a5e7211a; issue #1125 is closed.