Skip to content

fix(bench): preserve workflow receipt failures - #1126

Merged
DecisionNerd merged 1 commit into
mainfrom
fix/1125-preserve-workflow-failures
Sep 5, 2026
Merged

DecisionNerd merged 1 commit into
mainfrom
fix/1125-preserve-workflow-failures

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

A public-command workflow could report success after a child exited zero with an invalid JSON receipt: the child execution carried EvidenceInvalid, but workflow aggregation checked only the exit code and continued. Stop on either a nonzero exit or a recorded execution failure, preserving the original exit code, failure classification, prior receipts, cleanup details, timing, and RSS.

A real child-process regression proves valid zero-exit receipt sequences succeed, while an invalid second receipt stops the workflow after exactly two commands and retains only the preceding valid receipt. It failed before the fix (None instead of EvidenceInvalid) and passes afterward. Existing nonzero-exit handling remains covered.

Validation:

  • All 25 certifier tests passed; all-targets certifier Clippy with -D warnings passed.
  • Fresh CLI/certifier/generator binaries completed the real ten-phase tiny lifecycle, retaining 2 recount, 2 query, and 4 reopened-query receipts with matching source/imported results.
  • Fast checks, 14 gate-registry tests, and final formatting/diff checks passed.

This is the independent gate defect blocking #1119/#1124. Updating the new adjacency-probe receipt field remains in #1124; this change does not relax receipt validation or resource thresholds.

Closes #1125. Exact-head CI run 33950728612 passed at 78f76ee3bb28d02aae82b6c8829a3d9f2b7f5a88, with successful CI Gate, CLEAN merge state, and no unresolved review threads. Squash merged as 6a937da07a6ee9eb5ae5b2b4247f7432a5e7211a; issue #1125 is closed.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: de51d74c-e244-4335-b7a8-6ae55c5cb947

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DecisionNerd
DecisionNerd merged commit 6a937da into main Sep 5, 2026
21 checks passed
@DecisionNerd
DecisionNerd deleted the fix/1125-preserve-workflow-failures branch September 5, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(bench): stop workflows on receipt validation failures

2 participants