Repository navigation
Pick the NuGet feed with a source setting and skip mirror releases - #88
Merged
Merged
Conversation
A required source attribute in buildUtil/packages.config chooses between nuget.org and a GitHub release mirror, so switching feeds is a one-word change. It stays nuget.org, so the wheel is unchanged. The Build package workflow skips releases tagged nuget-packages-*, which will only host the mirror. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The build hook now picks its NuGet feed from a required
sourceattribute inbuildUtil/packages.config. The setting staysnuget.organd every pin stays at 23.0.3, so the wheel is the same as before.nuget.org: the existing flat-container URL, with the id and version lowercased.github-mirror:releases/download/nuget-packages-2026/{id}.{version}.nupkgon this repo, with the id cased as in the config."Build package" now skips both of its jobs (build and publish) for releases tagged
nuget-packages-*. Those releases will only hold the mirror of the 2026 native packages, which aren't on nuget.org yet, so creating one must not publish to PyPI. Arelease: publishedevent runs the workflow file from the tagged commit, so this guard has to be on master before the mirror release is created. Manual runs andv*releases work as before. On a manual run there's no release, sotag_nameis null, whichstartsWithtreats as''.Evidence
Checked by hand with
uv sync --reinstall-package mikecore:sourceattribute.source="nuget.org", the hook printsDownloading NuGet packages from nuget.organd fetches the same six api.nuget.org URLs as before.RuntimeError: buildUtil/packages.config: source must be one of nuget.org, github-mirror, got None.source="nuget", it stops with the same message ending ingot 'nuget'.The mirror URL hasn't been tried, because that release doesn't exist yet.
Merge Danger
Door: two-way. Reverting is enough; the PR changes no published artifacts.
Blast Radius: release-workflow
A wrong
if:expression could skip a realv*release, or let anuget-packages-*release publish. Tests can't catch either, so watch the first run of each.🤖 Generated with Claude Code