Fix propagation tag serialization for trace chunks - #12096
Fix propagation tag serialization for trace chunks#12096gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: c3e3dea | Docs | Datadog PR Page | Give us feedback! |
🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
dougqh
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for digging into this.
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
More details
The chunk mappers now source propagation metadata from the local root while emitting it only on chunk index zero, and the surrounding call-site review found no behavioral regression or unhandled input shape. No additional tests recommended: the PR already adds coverage for root-first and partial-chunk serialization across all three protocols.
🤖 Datadog Autotest · Commit c3e3dea · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
9a23583
into
master
What Does This Do
Serialize the root span’s
_dd.p.*propagation metadata on the first span of every V0.4, V0.5, and V1 protocol trace chunkMotivation
Trace chunks that do not include the root lose the trace-level propagation tags as seen in the problem that #12092, which is specific to
_dd.p.dm. Every chunk should carry this trace context exactly once.Additional Notes
The changes in this PR resolve the root’s propagation tags directly, so the patch fix in #12092 would no longer be needed.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]