Skip to content

Fix propagation tag serialization for trace chunks - #12096

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
sarahchen6/fix-dd-p-metadata-propagation
Jul 30, 2026
Merged

Fix propagation tag serialization for trace chunks#12096
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
sarahchen6/fix-dd-p-metadata-propagation

Conversation

@sarahchen6

Copy link
Copy Markdown
Contributor

What Does This Do

Serialize the root span’s _dd.p.* propagation metadata on the first span of every V0.4, V0.5, and V1 protocol trace chunk

Motivation

Trace chunks that do not include the root lose the trace-level propagation tags as seen in the problem that #12092, which is specific to _dd.p.dm. Every chunk should carry this trace context exactly once.

Additional Notes

The changes in this PR resolve the root’s propagation tags directly, so the patch fix in #12092 would no longer be needed.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Jul 28, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 85.19%
Overall Coverage: 58.00% (+0.21%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c3e3dea | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)

Suite Status
Startup 🟡 warning

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.94 s 13.96 s [-0.8%; +0.6%] (no difference)
startup:insecure-bank:tracing:Agent 12.85 s 12.99 s [-1.7%; -0.4%] (maybe better)
startup:petclinic:appsec:Agent 16.86 s 16.65 s [+0.1%; +2.4%] (maybe worse)
startup:petclinic:iast:Agent 16.85 s 16.95 s [-1.2%; +0.1%] (no difference)
startup:petclinic:profiling:Agent 16.77 s 16.86 s [-1.8%; +0.6%] (no difference)
startup:petclinic:sca:Agent 16.86 s 16.54 s [+0.8%; +3.0%] (maybe worse)
startup:petclinic:tracing:Agent 15.58 s 16.16 s [-7.6%; +0.5%] (no difference)

Commit: c3e3deaa · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@dougqh dougqh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for digging into this.

@sarahchen6
sarahchen6 marked this pull request as ready for review July 30, 2026 16:54
@sarahchen6
sarahchen6 requested a review from a team as a code owner July 30, 2026 16:54
@sarahchen6
sarahchen6 requested a review from PerfectSlayer July 30, 2026 16:54
@dd-octo-sts

dd-octo-sts Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@sarahchen6 sarahchen6 added type: feature Enhancements and improvements comp: core Tracer core labels Jul 30, 2026

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The chunk mappers now source propagation metadata from the local root while emitting it only on chunk index zero, and the surrounding call-site review found no behavioral regression or unhandled input shape. No additional tests recommended: the PR already adds coverage for root-first and partial-chunk serialization across all three protocols.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit c3e3dea · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@sarahchen6
sarahchen6 added this pull request to the merge queue Jul 30, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 30, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-30 17:01:53 UTC ℹ️ Start processing command /merge


2026-07-30 17:01:59 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-07-30 17:51:57 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 30, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 9a23583 into master Jul 30, 2026
592 of 596 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the sarahchen6/fix-dd-p-metadata-propagation branch July 30, 2026 17:51
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants