[IC3P3]

Fixes #222.

The game and company pages added a second <link rel="icon"> and it was correctly removed. However Firefox and Chrome both don't seem to update a removed tag and therefore the company or game one stays. As soon as you manually update the href of the favicon, the image updated in both Firefox and Chrome.

• Default favicon is now set once in the app.vue via useHead with a key favicon instead of the nuxt.config.ts
• The game and company page override it with the same key, game page favicon therefore re-enabled, works because with the same key, there can only be one favicon at a time and the <link> isn't removed, but updated
• useFavicon removed from both layouts

Testing

• I have tested the navigation between game, company, start, admin and error page
• Also works with custom favicons
• Works in both Firefox and Chrome
• Doesn't work in GNOME Web/WebKitGTK as this one seems to completely ignore the favicon updates during runtime, so I guess it isn't really fixable

[DecDuck]

Lint/typecheck failed, but it looks unrelated to your change. Will take a look.

[IC3P3]

I don't know if that has something to do with a Dependabot update, because I already got this as a warning when installing the packages.

Edit: #531 seems to have caused this, Dependabot updated the package.json, but not the pnpm-lock.yaml. If you want, I can open another PR fixing it

[DecDuck]

Nah it's allg, I just pushed the fix after running pnpm install. If you merge from develop, it'll probably fix it