Repository navigation
fix: snapshot queued plan acceptance identity - #313
EvanProgramming wants to merge 4 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Follow-up to #245. Stacked on PR #314, which contains the independent Anthropic SDK test compatibility fix.
Root cause
TUI and Web plan acceptance could lose the reviewed proposal's ID and version across worker or awaited-control boundaries. If the proposal changed during that gap, acceptance could target a newer proposal.
Approach
Capture the reviewed plan ID and version synchronously at TUI/Web dispatch. If no proposal exists, pass an invalid identity so a later proposal cannot be accepted implicitly. The existing core stale-identity check rejects any proposal revision that changes before execution.
Validation
plan_acceptanceisNone) and passes with the fix; the newer proposal remains pending.make test: 1,031 tests passed, 2 skipped on Python 3.12.make check,make lint,make docs-check, andmake agent-acceptancepassed locally.4b9c2eb867e3fe5e141f6fa346c2ae11da25a58eand reported no findings. The commit signature verifies with the existing GPG key.Risk
No public API or runtime behavior outside plan-acceptance dispatch changes. Live benchmark calls were not made.