Skip to content

fix: snapshot queued plan acceptance identity - #313

Open
EvanProgramming wants to merge 4 commits into
Evan/anthropic-sdk-auth-testfrom
Evan/plan-acceptance-followup
Open

EvanProgramming wants to merge 4 commits into
Evan/anthropic-sdk-auth-testfrom
Evan/plan-acceptance-followup

Conversation

@EvanProgramming

@EvanProgramming EvanProgramming commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Follow-up to #245. Stacked on PR #314, which contains the independent Anthropic SDK test compatibility fix.

Root cause

TUI and Web plan acceptance could lose the reviewed proposal's ID and version across worker or awaited-control boundaries. If the proposal changed during that gap, acceptance could target a newer proposal.

Approach

Capture the reviewed plan ID and version synchronously at TUI/Web dispatch. If no proposal exists, pass an invalid identity so a later proposal cannot be accepted implicitly. The existing core stale-identity check rejects any proposal revision that changes before execution.

Validation

  • Added a Web regression test that forces a new proposal during an awaited control. It fails against the pre-fix implementation (plan_acceptance is None) and passes with the fix; the newer proposal remains pending.
  • make test: 1,031 tests passed, 2 skipped on Python 3.12. make check, make lint, make docs-check, and make agent-acceptance passed locally.
  • Exact-head CI run 40685531089 passed Python, core, Docker persistence, and wheel/TUI acceptance jobs. Installer, installed-update, and separate TUI jobs were skipped by path classification.
  • Codex reviewed current head 4b9c2eb867e3fe5e141f6fa346c2ae11da25a58e and reported no findings. The commit signature verifies with the existing GPG key.
  • Current head is stacked on PR test: accept Anthropic SDK auth header variants #314; its seven-file diff excludes the separate Anthropic fixture change.

Risk

No public API or runtime behavior outside plan-acceptance dispatch changes. Live benchmark calls were not made.

@ghfind-review ghfind-review Bot added the review: high ghfind author score; see https://ghfind.com label Oct 28, 2026
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fa25b380-34d3-4216-92c9-ddea673bf711

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ghfind-review ghfind-review Bot added area:cli Command-line and terminal UI bug Something isn't working labels Oct 28, 2026
@EvanProgramming
EvanProgramming changed the base branch from main to Evan/anthropic-sdk-auth-test October 28, 2026 11:42
@EvanProgramming
EvanProgramming marked this pull request as ready for review October 28, 2026 11:50
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T12:12:03.019723Z 4b9c2eb Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@EvanProgramming
EvanProgramming changed the base branch from Evan/anthropic-sdk-auth-test to main October 28, 2026 11:59
@EvanProgramming
EvanProgramming changed the base branch from main to Evan/anthropic-sdk-auth-test October 28, 2026 12:00
@EvanProgramming
EvanProgramming changed the base branch from Evan/anthropic-sdk-auth-test to main October 28, 2026 12:09

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 4b9c2eb867

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@EvanProgramming
EvanProgramming changed the base branch from main to Evan/anthropic-sdk-auth-test October 28, 2026 12:15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:cli Command-line and terminal UI bug Something isn't working review: high ghfind author score; see https://ghfind.com

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant