Skip to content

test: accept Anthropic SDK auth header variants - #314

Open
EvanProgramming wants to merge 1 commit into
mainfrom
Evan/anthropic-sdk-auth-test
Open

EvanProgramming wants to merge 1 commit into
mainfrom
Evan/anthropic-sdk-auth-test

Conversation

@EvanProgramming

@EvanProgramming EvanProgramming commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Fixes an unrelated test assumption about the Anthropic SDK's authentication header. The fixture accepts either the SDK's x-api-key header or its equivalent bearer authorization header while still verifying the request host, system field, token limit, and message roles.

This change is separated from the queued plan-acceptance fix in PR #313. PR #313 is stacked on this branch so the full test suite remains green without mixing the two concerns.

Validation

  • Exact-head CI run 40662531308 passed core and Python tests at eb8d9cb84aa3e0de12dbd93ff00766f72caad418; path-filtered jobs were skipped.
  • Follow-up CI run 40682007722 passed the Python and core suites on the same exact head.
  • Codex reviewed head eb8d9cb84aa3e0de12dbd93ff00766f72caad418 and reported no findings.

Risk

This changes only a test assertion for equivalent SDK authentication header forms; no runtime code or public API changes.

@ghfind-review ghfind-review Bot added the review: high ghfind author score; see https://ghfind.com label Oct 28, 2026
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 354bfad0-1d6a-42eb-b093-5824cacc0440
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ghfind-review ghfind-review Bot added area: testing Test dependencies, fixtures, and acceptance coverage bug Something isn't working labels Oct 28, 2026
@EvanProgramming
EvanProgramming marked this pull request as ready for review October 28, 2026 11:50
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T11:51:53.422710Z eb8d9cb Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: testing Test dependencies, fixtures, and acceptance coverage bug Something isn't working review: high ghfind author score; see https://ghfind.com

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant