Repository navigation
docs(readme): list the five routes, their evidence, and what the VM tier proves - #127
TusanHomichi wants to merge 6 commits into
Conversation
…ier proves The README still described two routes (12 and 25 fixes) and said kernels, bootloaders and reboots were untested. Five routes now pass their current version on every box, and the maintainer-run VM tier has taken four of them through real reboots (wend#13). The layout section also predates the Ubuntu adapter, the VM tier, the archive and most of tools/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Permenter <41281403+TusanHomichi@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…from CI Review of 9b706a0 found that centos8-lamp passed the VM tier (#92), that the VM results are per box rather than per route (#84 for UEFI), and that the intro and layout still said every run came from CI. The client line now includes preflight. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Permenter <41281403+TusanHomichi@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Permenter <41281403+TusanHomichi@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Permenter <41281403+TusanHomichi@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Permenter <41281403+TusanHomichi@users.noreply.github.com>
|
Claude review: SIGN-OFF on head 8f2f13b An independent read-only review (a separate reviewer agent, not the author) checked this PR against the repo and the GitHub record. It ran in three passes: 9b706a0, then 3a10ef6, then the delta to 8f2f13b.
Filed separately: #128 ( No blocking findings. 🤖 Generated with Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f2f13bd59
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
SPEC.md "VM tier" says it is maintainer-run only and never wired to a CI runner a pull request can trigger (Codex review of 8f2f13b). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Permenter <41281403+TusanHomichi@users.noreply.github.com>
|
Claude review: SIGN-OFF on head 80fbbe0 The independent reviewer checked the one commit since its sign-off on 8f2f13b. It deletes "#13 stays open until the VM tier runs in CI", answering Codex's P2 (the thread is answered and resolved). SPEC.md "VM tier" (lines 1615-1616 on main) says the tier is maintainer-run only and never wired to a CI runner a pull request can trigger. With whitespace collapsed, the clause is the only change. No other sentence implies CI VM runs. The commit is signed off. No blocking findings. Every earlier point in the sign-off on 8f2f13b still holds. 🤖 Generated with Claude Code |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What this adds
README only. No route, fix, box, adapter or tool changes.
Route: none (documentation)
New fixes: none
Claims issue: none. Refs #13 (the README now summarizes its VM-tier results)
The README still described two routes (12 and 25 fixes) and said kernels, bootloaders and reboots were untested. This brings it up to date:
routeagainsttools/check.py --idsatf7278c9, and each counted run covers every hop. CI-attested runs: both Debian boxes andcentos5-web. The rest are local runs from before the attestation rule, and the README says so.etch-web,etch-db,trusty-db,trusty-web-updated,centos5-web,centos7-lampandcentos8-lampon BIOS (Routes don't test kernels, bootloaders or a real first boot #13, route: el centos8 -> alma10 #92), plus all three Ubuntu boxes on UEFI (hardware: Ubuntu routes boot on UEFI as on BIOS #84).runs/layout line no longer say every run came from CI; new runs do.service.recordandservice.enablecarry SysV runlevels onto systemd (SPEC open question 10).adapters/driversandadapters/leapp,archive/,docs/rebuild-and-carry.md,tools/vm.py, and the other tools. The client line now says it walks a root filesystem but not yet the running system.Model
none: documentation change, no fixes and no discovery runs.
Evidence
python3 wend checkat the head, underumask 022(what CI runners have): exit 0, ending68 fixes, 5 routes, 10 boxes, 84 runs: ok. An earlier version of this description said the gate's own tests passed, based on that last line. That was wrong for this host's defaultumask 0002: there it exits 1 becausetools/test_net_ifcfg.pydepends on umask, though it still printsok. Filed as wend check can end with 'ok' and still exit 1; test_net_ifcfg depends on umask #128; the same happens on main.python3 tools/affected.py origin/main:{"include": []}, so a README change replays nothing../wend verifywas not run: it needs root for the sandbox before it reads the (empty) matrix above.Self-review (AGENTS.md step 5)
./wend verifyfound no decoy hits (n/a: no fixes)repair) kept (n/a: no fixes)fires_on)git commit -s)Review
An independent read-only review of 9b706a0 found that the CentOS 8 VM pass (#92) was missing, that the VM results were stated per route instead of per box, and that the intro and layout still said every run came from CI. 1820bd1 and 3a10ef6 fix those. The stale SPEC bullet on Ubuntu's VM tier is filed as #129, since SPEC.md is owner-reserved.
🤖 Generated with Claude Code