feat(store): expose eligible pending mutation high-water - #1539
Merged
dnlrsls merged 1 commit intoSep 29, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dnlrsls
merged commit Sep 29, 2026
e7f5c14
into
Gentleman-Programming:feat/prompt-inbox-foundation-tracker
15 of 16 checks passed
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
Closes #1458
Child of tracker #1464. Target
feat/prompt-inbox-foundation-tracker, notmain; no remote delete behavior is enabled by this helper alone.🏷️ PR Type
type:bug— Bug fixtype:feature— New featuretype:question— Question requiring tracked worktype:docs— Documentation onlytype:refactor— Code refactoringtype:chore— Maintenancetype:breaking-change— Breaking change📝 Summary
sync_state.last_enqueued_seqdoes not hide pending eligible rows; exclude other targets, unenrolled, acknowledged and quarantined rows.📂 Changes
internal/store/store.gointernal/store/store_test.go71 additions, no transient artifacts. Documentation N/A: the new store read is not wired to autosync until a separate client preflight PR.
🧪 Test Plan
go test ./internal/store -run '^TestMaxPendingSyncMutationSeq$' -count=1— RED compile before implementation, GREEN afterward; independent PASS.go test ./internal/store -count=1— independent PASS.go vet ./internal/store,git diff --check, CRLF-normalized gofmt comparison — independent PASS. Native reviewreview-7c24726375ab72aeapproved/acknowledged.🤖 Automated Checks
All pending after opening; do not infer CI from local tests. Required checks must pass before normal merge.
✅ Contributor Checklist
type:*label (type:feature).💬 Notes for Reviewers
Compare this query with
ListPendingSyncMutationsAfterSeq: the predicates must agree. It is a prerequisite for a bounded autosync traversal that can skip an unverified full first page without starving later healthy rows. T4b3a2b will integrate it; T4b3b explicitly reauthorizes old/imported sources via per-source CLI; T4c still gates deletes remotely. Tracker #1464 stays outside main queue.