feat(autosync): preflight keyed prompt authority before push - #1540
Merged
dnlrsls merged 1 commit intoSep 29, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dnlrsls
merged commit Sep 29, 2026
9411cfc
into
Gentleman-Programming:feat/prompt-inbox-foundation-tracker
15 of 16 checks passed
9 of 17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
Closes #1458
Child of open tracker #1464, based on its latest head
e7f5c14d. Targetfeat/prompt-inbox-foundation-trackeronly; do not merge directly tomainor queue tracker yet.🏷️ PR Type
type:bug— Bug fixtype:feature— New featuretype:question— Question requiring tracked worktype:docs— Documentation onlytype:refactor— Code refactoringtype:chore— Maintenancetype:breaking-change— Breaking change📝 Summary
📂 Changes
internal/cloud/autosync/manager.gointernal/cloud/autosync/manager_test.gocmd/engram/autosync_e2e_test.godocs/codebase/prompt-inbox-provenance.md345 additions + 41 deletions = 386 changed lines. No duplicate store helper; it arrived through PR #1539.
🧪 Test Plan
go test ./internal/cloud/autosync ./cmd/engram ./internal/store -count=1— writer and independent verifier PASS.go veton these packages; gofmt listing andgit diff --check— PASS.review-a9bd33e5ba6528a1approved and acknowledged; two non-blocking advisories to inspect in follow-up.🤖 Automated Checks
Pending until CI runs; do not infer from local evidence. Performance ratchet and CodeRabbit may skip on this non-default base.
✅ Contributor Checklist
type:featurelabel.💬 Notes for Reviewers
Important follow-up before tracker/main validation: independent verification found that the existing
cycle()skips pull for any push failure. With this new fail-closed preflight, a permanently unverified keyed prompt can now keep inbound pull stalled on retries, even though later outbound entries progress. Tracked as T4b3a2c, a separate ≤400-line child to distinguish per-entry authorization failures from transport failures, permit safe pull, preserve failed outbound status and pending/no ack, and update the legacy skip-pull regression. This slice is not a claim that inbound starvation is solved. Do not queue #1464 until T4b3a2c, explicit per-source CLI reauthorization (T4b3b), cloud delete admission (T4c) and integrated validation (T5) are complete.