fix(gix-bitmap): Reject chunk length that overflows 32-bit usize - #3013
Merged
Sebastian Thiel (Byron) merged 1 commit intoSep 23, 2026
Conversation
Sebastian Thiel (Byron)
approved these changes
Sep 23, 2026
Sebastian Thiel (Byron)
left a comment
Member
There was a problem hiding this comment.
Thanks so much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I ran into this panic with the
ewahfuzz target on 32-bit platforms (i686, WASM):It happens in
gix_bitmap::ewah::decode(&[0, 0, 0, 0, 0x20, 0, 0, 0])becauselen * 8overflowsusize.This PR uses a checked multiplication instead.
saturating_mulwould also work but the explicit error message might be nice to have. Let me know if I should replace the patch with a single-linesaturating_mulone and/or add a test.Thanks!