Skip to content

fix(gix-bitmap): Reject chunk length that overflows 32-bit usize #3013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sebastian Thiel (Byron) merged 1 commit into from
Sep 23, 2026
Merged

fix(gix-bitmap): Reject chunk length that overflows 32-bit usize #3013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion gix-bitmap/src/ewah.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@ pub fn decode(data: &[u8]) -> Result<(Vec, &[u8]), decode::Error> {
// NOTE: git does this by copying all bytes first, and then it will change the endianness in a separate loop.
// Maybe it's faster, but we can't do it without unsafe. Let's leave it to the optimizer and maybe
// one day somebody will find out that it's worth it to use unsafe here.
let word_bytes_len = len
.checked_mul(std::mem::size_of::<u64>())
.ok_or_raise(|| message("chunk length overflows size calculation").into())?;
let (mut bits, data) = data
.split_at_checked(len * std::mem::size_of::<u64>())
.split_at_checked(word_bytes_len)
.ok_or_raise(|| message("eof while reading bit data").into())?;
let mut buf = std::vec::Vec::<u64>::with_capacity(len);
for _ in 0..len {
Expand Down
Loading