Skip to content

Improve README onboarding, package dependencies, and CHANGELOG handoff - #256

Open
HomenShum wants to merge 4 commits into
mainfrom
codex/repository-entry-20261007
Open

HomenShum wants to merge 4 commits into
mainfrom
codex/repository-entry-20261007

Conversation

@HomenShum

@HomenShum HomenShum commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Developers and coding agents get a clear onboarding entry and patched compatible dependencies without changing NodeRoom's runtime or release gates. This PR retains the direct Undici 8.11.2 repair and updates the locked DOMPurify sanitizer from 3.4.14 to 3.4.17 within Mermaid's existing supported range. The repository changelog preserves the before/after evidence and remaining failures.

The new sanitizer follow-up changes only three lock fields and appends the changelog. All 1,078 other lock records remain identical to the previous PR head c8789df42a425f6d101ecfac8e29a0cfa4b06eb9, including both Undici versions. Manifests, README, application code, tests and proof assets are unchanged by this follow-up.

Local evidence on Node 22.22.2:

  • Clean installation with lifecycle scripts disabled succeeds. Installed and locked versions match the published package integrity.
  • The identical production audit command reports 11 low affected package nodes before → 10 low after, removing DOMPurify; no moderate/high/critical finding is reported. All remaining vulnerability records are unchanged. This is a threshold pass, not a zero-vulnerability certificate.
  • Application and Convex typechecks pass. The canonical floor reports 2,779 passing tests and one failure: the existing product proof is 45.6 days old against its unchanged 30-day window.
  • The canonical build and build-provenance check pass with the local patch. Existing source-map and large-chunk warnings are retained. Mocked network and jsdom scenarios do not certify real TLS behavior or pixel quality.

Release remains blocked by authentic fresh-user proof and the full required gates. No timestamp, freshness policy, claim, checker or CI condition was relaxed. The low KaTeX chain remains: its patched release is outside the current incoming ranges, so a broader renderer migration is separate work. No forced override or dependency suppression was added.

Earlier failed executions remain in history and in CHANGELOG/qa/production-gate.md; this amendment does not make them pass. Exact follow-up identity, independent review and natural CI results will be appended after publication. No merge, production deployment, application model call or paid evaluation is claimed.

Follow-up candidate: fa5c3df1ea750c9c0c7db0d6a0ab14cfbba29f83, tree f159b0761ec88cb2e408b9b10a310662d8c71b7d, sole parent c8789df42a425f6d101ecfac8e29a0cfa4b06eb9. Independent code and simplification reviews approve this exact two-file amendment for PR publication only; the review independently verified the registry tarball digest. Its direct commit-area check passes. Natural CI is pending; merge remains blocked.

Natural CI for fa5c3df1 is now FAILED in both PR verify and push verify. Both ordinary lifecycle-enabled installs succeed and report 17 all-dependency findings (10 low, 4 moderate, 3 high). Their production-only audits report 10 low findings and clear the unchanged moderate threshold; subsequent checks proceed until proofs:staleness rejects the same 45.6-day-old receipt against its 30-day window. Later production-gate steps remain unreached. The exact direct push passes its two-area commit-message check. No gate was bypassed and this PR remains unmerged.

Add one early navigation paragraph to the current four-file start section and Quickstart. Preserve all existing proof, media and history text.

Co-authored-by: Codex <noreply@openai.com>
@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
noderoom Ready Ready Preview Oct 14, 2026 2:13pm UTC

Request Review

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Scaffold Handoff — For Your Coding Agent

Your coding agent (Codex, Claude Code, etc.) should apply the accepted
scaffold proposals below. Do NOT touch any immutable files.

Immutability Check

Mode: advisory

✅ No immutable files were modified in this branch.

Changed Files

  • CHANGELOG/qa/production-gate.md
  • README.md
  • docs/eval/OFFICIAL_BENCHMARK_READINESS.md
  • docs/eval/OFFICIAL_BENCHMARK_TASK_COVERAGE.md
  • docs/eval/OPENROUTER_CONVEX_BENCHMARK.md
  • docs/eval/agent-improvement-loop.md
  • docs/eval/agent-improvement-loop.svg
  • docs/eval/agent-improvement-loop/20261014T141249Z.json
  • docs/eval/agent-improvement-loop/latest.json
  • docs/eval/agent-workspace-sandbox-smoke.json
  • docs/eval/algorithm-artifact-smoke.json
  • docs/eval/bankertoolbench-official-contract.json
  • docs/eval/docker-sandbox-probe.json
  • docs/eval/eval-runs.jsonl
  • docs/eval/halo-convex-context-telemetry.json
  • docs/eval/halo-self-improvement-smoke.json
  • docs/eval/halo-variant-selection.json
  • docs/eval/official-benchmark-readiness.json
  • docs/eval/official-benchmark-task-coverage.json
  • docs/eval/openrouter-convex-benchmark.json
  • docs/eval/professional-catalog-proofs.json
  • docs/eval/professional-proof-ledger.json
  • docs/eval/spreadsheetbench-chart-visual-probe.json
  • docs/eval/traces/credit/20261014T141258093Z-8cf17b68_dirty.4ba16c6ae3e30384/cascade-healthy.json
  • docs/eval/traces/credit/20261014T141258093Z-8cf17b68_dirty.4ba16c6ae3e30384/delta-incomplete.json
  • docs/eval/traces/credit/20261014T141258093Z-8cf17b68_dirty.4ba16c6ae3e30384/mapping-correct.json
  • docs/eval/traces/credit/20261014T141258093Z-8cf17b68_dirty.4ba16c6ae3e30384/mapping-misbind.json
  • docs/eval/traces/credit/20261014T141258093Z-8cf17b68_dirty.4ba16c6ae3e30384/summit-stressed.json
  • docs/eval/traces/ladder/20261014T141257641Z-8cf17b68_dirty.7ad8764c650f0fc9/ladder_L1_read_scripted.json
  • docs/eval/traces/ladder/20261014T141257641Z-8cf17b68_dirty.7ad8764c650f0fc9/ladder_L2_edit_scripted.json
  • docs/eval/traces/ladder/20261014T141257641Z-8cf17b68_dirty.7ad8764c650f0fc9/ladder_L3_conflict_scripted.json
  • docs/eval/traces/ladder/20261014T141257641Z-8cf17b68_dirty.7ad8764c650f0fc9/ladder_L4_blocked_scripted.json
  • docs/eval/traces/ladder/20261014T141257641Z-8cf17b68_dirty.7ad8764c650f0fc9/ladder_L5_large_range_scripted.json
  • docs/eval/traces/ladder/20261014T141257641Z-8cf17b68_dirty.7ad8764c650f0fc9/ladder_L6_long_horizon_scripted.json
  • docs/eval/traces/ladder/20261014T141257641Z-8cf17b68_dirty.7ad8764c650f0fc9/ladder_L7_resume_scripted.json
  • package-lock.json
  • package.json

Needs Adversarial Review — Do NOT Apply Yet

These proposals passed the reject check but have not been approved by
an adversarial reviewer. A human or frozen LLM judge must approve them first.

  • scaf-001 (AGENTS.md): Add explicit instruction for step spreadsheetbench-runner-fixture: Step spreadsheetbench-runner-fixture failed — scaffold may need explicit instruction or evidence assertion.
  • scaf-002 (AGENTS.md): Add explicit instruction for step convex-boundaries: Step convex-boundaries failed — scaffold may need explicit instruction or evidence assertion.

Safety Boundary

Agent may improve the scaffold.
Agent may NOT weaken the proof gate.

Immutable files (never modify):

  • scripts/proofloop.mjs
  • scripts/agent-improvement-loop.ts
  • tests/harnessChangeEval.test.ts
  • .github/workflows/
  • src/eval/evalTrustPolicy.ts
  • src/eval/architectureBudget.ts
  • evals/evalStore.ts

Scaffold files (safe to modify):

  • AGENTS.md
  • CLAUDE.md
  • proofloop/scenarios/*.yaml
  • proofloop/rubrics/*.yaml
  • proofloop/subagents/*.md
  • proofloop/adapters/*.js
  • .proofloop/memory.jsonl
  • src/nodeagent/models/prompts/systemPrompt.ts

@HomenShum HomenShum changed the title docs: expose developer starting points before media Improve repository onboarding and update direct Undici Oct 9, 2026
@HomenShum HomenShum changed the title Improve repository onboarding and update direct Undici Improve README onboarding, package dependencies, and CHANGELOG handoff Oct 9, 2026
Resolve DOMPurify 3.4.17 within the existing Mermaid range. Preserve all other
lock records, including the reviewed Undici repair, and append the measured
audit reduction, successful build and unchanged stale-proof failure.

This branch was successfully deployed

1 active deployment
Preview — fa5c3df1 Deployed Oct 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant