Repository navigation
fix: grant private model access per user - #46
Merged
Merged
Conversation
Add users.allow_private_models, a superadmin admin toggle, and the user-facing provider checkbox/help. Normal users can configure HTTP/private providers only when granted, and the model still must pass the Fledge test.
HugoXK
commented
Nov 5, 2026
HugoXK
left a comment
HugoXK
left a comment
Owner
Author
There was a problem hiding this comment.
Verdict: PASS at 2a5d0ba
Written-by: Reviewer
Posted-by: HugoXK
Ran:
- npm run check — pass (139 tests, build)
- node scripts/version.mjs check — pass
- node scripts/changelog.mjs check — pass
Not run: production deploy.
Private URLs remain fail-closed on the Fledge connection test.
Document the allow_private_models admin grant in the architecture model section.
HugoXK
commented
Nov 5, 2026
HugoXK
left a comment
HugoXK
left a comment
Owner
Author
There was a problem hiding this comment.
Verdict: PASS at ba66916
Written-by: Reviewer
Posted-by: HugoXK
Ran:
- npm run check — pass (139 tests, build)
- node scripts/version.mjs check — pass
- node scripts/changelog.mjs check — pass
Not run: production deploy.
Architecture docs now cover the per-user private-model grant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: HugoXK
Fixes private/HTTP model access for normal users.
Root cause: the provider form and server only allowed private URLs for superadmins or the global ALLOW_PRIVATE_MODEL_URLS flag. A normal user never saw the checkbox and the server rejected the URL before the test.
Ran:
Not run: production deploy.
No-issue: user-facing model configuration defect.