Repository navigation
fix: migrate the private model flag on users - #47
Merged
Merged
Conversation
The allow_private_models column was added to the repos migration list instead of users, so existing databases never got the user column. Move the migration to the users additions and assert the flag persists.
HugoXK
commented
Nov 5, 2026
HugoXK
left a comment
HugoXK
left a comment
Owner
Author
There was a problem hiding this comment.
Verdict: PASS at 55d47d0
Written-by: Reviewer
Posted-by: HugoXK
Ran:
- npm run check — pass (140 tests, build)
- node scripts/version.mjs check — pass
- node scripts/changelog.mjs check — pass
Not run: production deploy.
This is a migration-placement fix; the user column is added on startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: HugoXK
Fixes the users migration for the private-model flag.
The allow_private_models column was added to the repos migration list instead of the users list, so existing databases reached schema 27 without the user column. Move it to the users additions and assert the flag persists.
Ran:
Not run: production deploy.
Docs-not-needed: the architecture model section already documents the per-user allow_private_models grant; this PR only fixes the migration placement.
Changelog-not-needed: migration placement fix; the user-facing private model grant is already covered by #46.
No-issue: follow-up to the private-model access fix.