Skip to content

fix: migrate the private model flag on users #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HugoXK merged 1 commit into from
Nov 5, 2026
Merged

fix: migrate the private model flag on users #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/db.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,6 +728,7 @@ export class Store {
['email_job_updates', 'INTEGER NOT NULL DEFAULT 1'],
['email_daily_digest', 'INTEGER NOT NULL DEFAULT 1'],
['notify_email', 'TEXT'],
['allow_private_models', 'INTEGER NOT NULL DEFAULT 0'],
['github_token_scopes', 'TEXT'],
]
for (const [name, type] of additions) {
Expand All @@ -747,7 +748,6 @@ export class Store {
['allow_paths', "TEXT NOT NULL DEFAULT ''"],
['deny_paths', "TEXT NOT NULL DEFAULT ''"],
['merge_method', "TEXT NOT NULL DEFAULT 'squash'"],
['allow_private_models', 'INTEGER NOT NULL DEFAULT 0'],
['require_protection', 'INTEGER NOT NULL DEFAULT 1'],
['stage_mode', "TEXT NOT NULL DEFAULT 'off'"],
['models_dirty', 'INTEGER NOT NULL DEFAULT 0'],
Expand Down
12 changes: 12 additions & 0 deletions test/db.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,3 +371,15 @@ test('repository bot model assignments persist and are cleaned with the selectio
store.close()
}
})

test('the per-user private model permission persists', () => {
const store = new Store(':memory:')
try {
const user = makeUser(store, { login: 'private-permission-user', status: 'approved' })
assert.equal(store.userById(user.id)?.allow_private_models, 0)
store.setUserAllowPrivateModels(user.id, true)
assert.equal(store.userById(user.id)?.allow_private_models, 1)
} finally {
store.close()
}
})
Loading