Repository navigation
Resolve #388 - #1340
Merged
adkinsrs merged 2 commits intoOct 2, 2026
Merged
Resolve #388#1340
Conversation
…e input handling in forms and UI
adkinsrs
deleted the
388-enabling-deletingadding-genes-when-editing-gene-carts
branch
October 5, 2026 13:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for editing the genes in an "unweighted-list" gene cart directly from the user interface. It introduces a new editable textarea for gene symbols, updates the backend to handle gene list changes, and ensures the database is updated properly when genes are modified. The changes also improve the user experience by updating the gene count and preview dynamically.
Backend changes for gene list editing:
save_membersmethod and aremove_all_membersmethod to the gene cart model inlib/geardb.py, allowing for safe replacement of gene cart members when editing. [1] [2]savemethod inlib/geardb.pyto use the newsave_membersmethod for "unweighted-list" carts, ensuring that gene members are properly handled on save.save_genecart_changes.cgito accept and process agenesparameter, cleaning and splitting the input, and updating the gene cart members accordingly. [1] [2]Frontend changes for gene list editing:
gene_list_manager.htmlto include a new editable textarea for genes when editing "unweighted-list" gene carts.gene_list_manager.jsto show/hide the gene textarea appropriately, fetch and display current gene symbols, and send gene changes to the backend. The gene count and preview are updated after edits. [1] [2] [3]common.v2.jsto allow sending an optionalgenesfield in the save request payload.User interface improvements:
Minor code cleanup:
search_gene_carts.cgi.geardb.pyregarding foreign key cascade deletes.