Migrate DAVE to ROS 2 Lyrical and Gazebo Jetty - #65
Open
yeseorizi wants to merge 9 commits into
Open
Conversation
Signed-off-by: yeseorizi <172019512+yeseorizi@users.noreply.github.com>
Signed-off-by: yeseorizi <172019512+yeseorizi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ros2branch from ROS 2 Jazzy / Gazebo Harmonic to ROS 2 Lyrical / Gazebo JettyScope
This PR is based directly on the current
ros2branch and is independent of PR #44. It does not include or modify the WGPU implementation, shader, range-axis correction, or research experiment files.Validation
package.xml, and Dockerfile static checks passedardupilot_gazebobuilt against Gazebo Jettyardupilot_gazebowere addeddave_*packages plusmultibeam_sonarandmultibeam_sonar_systemwere discoverabledvl_worldstarted headlessly and advertised the expected Gazebo world clock/statistics topicxrdp,xrdp-sesman, and system DBus, and TCP port 3389 accepted a connectionPull-request jobs are build-only. No Docker Hub image is pushed from a pull-request event.
Remaining post-merge check
The repository contains the
DOCKERHUB_USERNAMEandDOCKERHUB_TOKENsecret names, but their values cannot be read from GitHub. Their current validity and the final image pull/run check can only be confirmed by the firstros2push workflow after merge.Local limitation
The local validation machine has no NVIDIA CUDA toolkit. CUDA compilation and runtime behavior are therefore not claimed by this PR. The separate WGPU work in PR #44 is also not part of this migration.