Skip to content

add:通知显示新增位置底栏上方 - #695

Open
chenjei2011 wants to merge 3 commits into
InkCanvasForClass:net10from
chenjei2011:net10
Open

chenjei2011 wants to merge 3 commits into
InkCanvasForClass:net10from
chenjei2011:net10

Conversation

@chenjei2011

@chenjei2011 chenjei2011 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

需求动机

#691

功能描述

在设置->通知->通知设置->灵动通知位置新增选项底栏上方,若启用此选项,浮动栏情况下与浮动栏上方选项一致,进入白板后若有灵动通知显示在白板工具栏上方

前端更改(看样式)

捕获

后端更改

新增ApplyDynamicNotificationBottomBarPlacement函数用来响应底栏上方这个选项

@augmentcode

augmentcode Bot commented Oct 6, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Adds the “Above bottom bar” dynamic-notification placement option requested in #691.
Adds BottomBarAbove to the notification settings dropdown.
Routes the option through ApplyDynamicNotificationBottomBarPlacement.
Reuses floating-toolbar positioning when the floating toolbar is visible.
Positions notifications above the central whiteboard toolbar, with edge clamping and a top-center fallback when unavailable.
Adds Chinese and English resource labels and the corresponding resource accessor.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

var bottomRight = BlackboardCenterSide.TranslatePoint(
new Point(BlackboardCenterSide.ActualWidth, BlackboardCenterSide.ActualHeight), this);
double notificationWidth = DynamicNotification.ActualWidth > 0 ? DynamicNotification.ActualWidth : DynamicNotification.Width;
double notificationHeight = DynamicNotification.ActualHeight > 0 ? DynamicNotification.ActualHeight : 72;

@augmentcode augmentcode Bot Oct 6, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At Ink Canvas/MainWindow_cs/MW_Notification.cs:256, consider a ForcePopup notification or clicking to expand one in whiteboard mode: placement runs before DynamicNotification.Show populates the control, and subsequent size changes never recalculate this margin. Using the previous message's height or 72 means expanded content can overlap the bottom toolbar and be clipped at the window's lower edge.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

ApplyDynamicNotificationFloatingBarPlacement();
break;
case "BottomBarAbove":
ApplyDynamicNotificationBottomBarPlacement();

@augmentcode augmentcode Bot Oct 6, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At Ink Canvas/MainWindow_cs/MW_Notification.cs:188, consider entering whiteboard mode while a notification is already visible: ApplyDynamicNotificationPlacement runs only when a notification is requested, and SwitchBackground never recalculates its margin. The notification therefore remains at the desktop floating-toolbar coordinates instead of moving above BlackboardCenterSide, and similarly retains the whiteboard position on exit.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@doudou0720 doudou0720 linked an issue Oct 6, 2026 that may be closed by this pull request
5 of 6 tasks
@CJKmkp

CJKmkp commented Oct 7, 2026

Copy link
Copy Markdown
Member

我建议将相关逻辑合并入浮动栏上方,而不是新增选项

@chenjei2011

chenjei2011 commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor Author

ok,等我有空就改

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

允许白板中灵动通知显示在工具栏上

2 participants