Skip to content

update: startAmbush() also mutes sack sound - #142

Merged
Zamiell merged 1 commit into
IsaacScript:mainfrom
KOSMOGOR:start-ambush
Oct 8, 2026
Merged

Zamiell merged 1 commit into
IsaacScript:mainfrom
KOSMOGOR:start-ambush

Conversation

@KOSMOGOR

@KOSMOGOR KOSMOGOR commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Zamiell

Zamiell commented Oct 8, 2026

Copy link
Copy Markdown
Member

the conditional is pointless, right?

@KOSMOGOR

KOSMOGOR commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

theoretically, it can stop sound of opening another sack... but this will happen very rarely

@Zamiell

Zamiell commented Oct 8, 2026

Copy link
Copy Markdown
Member

is SoundEffect.SHELL_GAME the sound of touching a sack?

@KOSMOGOR

KOSMOGOR commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

yes

@Zamiell

Zamiell commented Oct 8, 2026

Copy link
Copy Markdown
Member

ok i see now.
i was confused because i thought that wasPlayingSound happened on the same frame, but now I see that it happens on the previous frame.
thanks for the PR.

@Zamiell
Zamiell merged commit 954f52c into IsaacScript:main Oct 8, 2026
24 checks passed
@Zamiell

Zamiell commented Oct 8, 2026

Copy link
Copy Markdown
Member

published isaacscript-common v87.10.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants