Skip to content

update: startAmbush() also mutes sack sound #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zamiell merged 1 commit into from
Oct 8, 2026
Merged

update: startAmbush() also mutes sack sound #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/isaacscript-common/src/classes/features/other/StartAmbush.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { SackSubType } from "isaac-typescript-definitions";
import { SackSubType, SoundEffect } from "isaac-typescript-definitions";
import { sfxManager } from "../../../core/cachedClasses";
import { Exported } from "../../../decorators";
import { ISCFeature } from "../../../enums/ISCFeature";
import { removeEntities } from "../../../functions/entities";
Expand Down Expand Up @@ -42,6 +43,7 @@ export class StartAmbush extends Feature {
player.Position,
SACK_SEED_THAT_SPAWNS_TWO_COINS,
);
const wasPlayingSound = sfxManager.IsPlaying(SoundEffect.SHELL_GAME);

// The sack will play the "Appear" animation and the player will not be able to interact with it
// while this is occurring. By stopping the animation, it will transition to the "Idle"
Expand All @@ -54,6 +56,9 @@ export class StartAmbush extends Feature {
if (futureSack === undefined) {
return;
}
if (!wasPlayingSound) {
sfxManager.Stop(SoundEffect.SHELL_GAME);
}

futureSack.Remove();
const sackPtrHash = GetPtrHash(futureSack);
Expand Down
Loading