Skip to content

Phase 5: sort checking and the argument library - #7

Merged
JFrusher merged 1 commit into
phase-4-webfrom
phase-5-fol
Oct 24, 2026
Merged

JFrusher merged 1 commit into
phase-4-webfrom
phase-5-fol

Conversation

@JFrusher

Copy link
Copy Markdown
Owner

Stacked on #6. Implements Phase 5 of ROADMAP.md. The first-order proof rules landed in Phase 3, so this phase adds what was still missing.

  • Sort checker (src/core/types.cpp, spec in docs/spec/language.md §6): every free name gets exactly one type (individual, proposition, predicate, or property) across node formulas, proof lines, objections and definitions. Arity clashes, applying an individual variable, multi-place predicates used as terms, identity between properties, and λ over non-individuals are all errors. It runs before proof checking, so the proof rules never see ill-sorted formulas.
  • library/arguments/ (feeds the gallery): Aquinas's First Way, the kalam cosmological argument (new, fully proved, with two objections and replies), and the resurrection argument.
  • examples/: modus ponens, plus a deliberately invalid "affirming the consequent" that shows counterexample Rain = false, Wet = true.

66 test cases pass; the WASM and Playwright smoke tests pass against the new layout.


Generated by Claude Code

- Sort checker: every free name gets one type (individual, proposition,
  predicate over individuals/properties, property) across node formulas,
  proof lines, objections and definitions; runs before proof checking
- Spec section on sorts; tests for inference and each class of clash
- library/arguments/: Aquinas's First Way, the kalam cosmological argument
  (new, with two objections and replies) and the resurrection argument
- examples/: modus ponens and a deliberately invalid argument showing the
  counterexample output
- Gallery, playground, tests and README follow the new layout

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019WEmxyo9CRKSbjbEdCuJTG
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c4c01660-d2dc-436c-8feb-51be6615f5ba
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JFrusher
JFrusher marked this pull request as ready for review October 24, 2026 23:22
@JFrusher
JFrusher merged commit 55f23ce into phase-4-web Oct 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants