Scope ONPRC billing run deletion to the current container#1759
Open
labkey-martyp wants to merge 2 commits into
Open
Scope ONPRC billing run deletion to the current container#1759labkey-martyp wants to merge 2 commits into
labkey-martyp wants to merge 2 commits into
Conversation
deleteBillingRuns built SimpleFilters over the raw onprc_billing tables (invoicedItems, invoiceRuns, miscCharges) from request-supplied primary keys with no container predicate, so a billing admin in one folder could delete or detach billing rows belonging to any other folder by POSTing arbitrary object IDs. Thread the caller's Container into the method and add a container filter to every read, delete, and update so the operation is confined to the current folder. Add an integration test (ONPRC_BillingManager.TestCase) asserting that a delete issued from one container cannot affect another, and register it in ONPRC_BillingModule.getIntegrationTests(). Also drop two unused row-count locals from the Table.delete calls.
labkey-bpatel
previously approved these changes
Jun 16, 2026
Mirror the ehr_billing fix (ehrModules#1146): narrow the requested run ids to those that actually exist in the requesting container, then match misc charges by run id alone rather than container. Source miscCharges records can live in containers other than the billing/finance container (the EHR study container or satellite source containers), so a container-scoped filter silently failed to detach them. The run ids are already authorized against the requesting container, so matching by invoiceId only is safe and complete. Adds a satellite-source-container case to the delete test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
ONPRC_BillingManager.deleteBillingRuns built SimpleFilters over the raw onprc_billing tables (invoicedItems, invoiceRuns, miscCharges) from request-supplied primary keys with no container predicate, and the method received no Container. Since DeleteBillingPeriodAction's permission check is evaluated only against the current folder, a billing admin in one folder could delete or detach billing rows belonging to any other folder by POSTing arbitrary object IDs — a cross-container horizontal privilege-escalation bug. This change confines every operation to the caller's folder.
Related Pull Requests
Changes