Repository navigation
Conversation
dnlbui
force-pushed
the
test/retain-failure-diagnostics
branch
from
October 5, 2026 16:19
74095be to
3237bb3
Compare
dnlbui
changed the base branch from
test/settle-attachment-menu-scroll
to
test/reply-within-toll-window
October 5, 2026 16:19
Contributor
Author
|
closing for now until we decide to merge this in since this is a larger PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Failed setup and lookup attempts now retain the evidence needed to distinguish client, gateway, and test failures.
Fixed Flow
Why
The original CI failures could not distinguish unavailable registration receipts, delayed username availability, transport errors, or negative lookup responses. First-attempt traces were lost, and cleanup could hide the failing page. These changes improve failure reporting without automatically retrying registration or accepting an incorrect lookup result.
The application recovery defect is addressed separately in web-client-v2 #1744.
Validation
Rebase verification (October 5, 2026):
git range-diffconfirms the diagnostics patch is unchanged. Both multi-user tests passed against/devwith two workers and retries disabled, including the inherited reply-toll fix.npm run test:diagnosticsagain verified all nine cases and the retained artifacts from the two deliberate first-attempt failures.https://liberdus.com/dev/passed with retries disabled.npm run test:diagnostics: nine offline cases verified; two deliberately fail their first attempt to verify retained artifacts after a successful retry.git diff --checkpassed.Stacked on #87 (reply-toll timing fix); review this PR against
test/reply-within-toll-window, which is based on #83. The diagnostics changes are unchanged by this rebase.Closes #78