Repository navigation
Conversation
dnlbui
added this pull request to stack #88
October 5, 2026 16:26
dnlbui
marked this pull request as ready for review
October 5, 2026 16:26
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
The read-and-reply toll test now waits for the expected reward balances instead of spending the reply window in fixed sleeps.
expectLiberdusBalanceToEqual()for bounded checks of both reward balances.Fixed Flow
Send the paid message → wait for its arrival → confirm the read reward → reply → confirm the reply reward.
Why
In run 37319184103, all three replies arrived just after the network's 60-second reward deadline (60.333–60.837 seconds). The server accepted the replies but correctly omitted the expired reward. Removing unnecessary waits lets the test verify both rewards within the window.
Validation
Against
https://liberdus.com/dev/, three consecutive Chromium runs passed with retries disabled. Captured transaction timestamps show replies at 34.906, 36.429, and 36.296 seconds, leaving over 23 seconds of margin.After rebasing #84 onto this branch, both multi-user tests passed with two workers and retries disabled:
CI=true ./node_modules/.bin/playwright test tests/multiUser.e2e.test.js --project=chromium --workers=2 --retries=0 --trace=on --reporter=line --output=/tmp/liberdus-reply-toll-85-stackedThe rebased stack also passed
npm run test:diagnostics(nine cases, including two intentional first-attempt failures whose retained artifacts are verified).git range-diffconfirmed the diagnostics patch is unchanged.node --check,git diff --check, and a separate make-code-skimmable review passed. The diff changes one test and adds no new helpers or options. The full 84-test suite was not rerun for this focused change.Stack: #83 → #87 → #84. Review this PR against
test/settle-attachment-menu-scroll.Closes #85