Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Account creation now leaves the loading state when an accepted registration cannot be confirmed.
CreateAccountModalowns a bounded 35-second receipt check and offers Check account status while preserving the original identity.Fixed Flow
Accepted registration → save original identity → bounded confirmation checks → sign in on confirmation, report explicit rejection, or show a recoverable confirmation-unavailable state.
Check account status reuses that identity after a reload. It does not resubmit registration.
Why
The shared pending checker could remove an unconfirmed transaction after its deadline without settling the promise awaited by Create Account. The screen remained on “Creating account…” indefinitely. Modal-owned confirmation also avoids depending on a shared polling request that can remain stalled.
Missing confirmation is not proof that registration failed, so recovery preserves the original account and checks authoritative state before proceeding.
Validation
node tests/registration-confirmation.test.cjs— 17 passed, covering null/empty/malformed/stalled responses, success/rejection, late confirmation, matching/conflicting aliases, original-identity binding, reload, private accounts, device-lock changes, account removal, and wallet-refresh failure.node --check app.jsandgit diff --checkpassed.Scope is confirmation recovery after accepted registration; submission-stage network handling is separate.
Closes #1742