Repository navigation
feat: full attribute filters on metrics widgets, create_dashboard where/unit/series count - #1388
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Oct 12, 2026 in 4m 43s
Confidence 9/10 · No issues found
🟢 Confidence 9/10 · safe to merge
Both follow-up fixes (quoteWhereValue, numeric present guard) are correct, pinned by tests, and reach no other caller.
quality 100/100 · no findings · tests covered · risk medium
Adds full attr.* operator support to metric datapoint filters end to end, plus where/unit on create_dashboard simple widgets and a seriesCount in widget validation. The follow-up fixes at this head are correct; safe to merge.
buildAttrFilterConditionrequires a non-empty label forattr.x < / <= / >/>=create_dashboardservice_name goes throughquoteWhereValuein the widget where clause- Metrics queries and the runtime take the whole
attributeFilterslist WidgetInspectionEntryreportsseriesCountfrom the largest query
What was checked
quoteWhereValuealways quotes, andsplitOnKeyword/unquoteare quote-aware, so"in a service name cannot open a clause (where-clause.ts:96,132)presentonly drops missing/empty labels;gt 0andequalsbehaviour is unchanged- OR-group members still compare against the empty accumulator, so
metricNamecannot makesetsOtherFieldtrue
b4ebf3c · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading